-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] delivery_price_product_domain: fix shipping without rule #772
[14.0][FIX] delivery_price_product_domain: fix shipping without rule #772
Conversation
Hi @solo4games, @CetmixGitDrone, |
c0cea2f
to
6116a42
Compare
170b17d
to
5f83211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok
@rousseldenis what do you say?
This PR has the |
@pedrobaeza can we merge? |
@rousseldenis should confirm |
@rousseldenis does it look good for you? thanks! |
cfbe3c7
to
053b398
Compare
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-772-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@chienandalu as author of https://github.com/OCA/delivery-carrier/tree/14.0/delivery_cttexpress , could you help us understand whether the error in tests is temporary or needs fixing? thanks! |
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at c2a5e70. Thanks a lot for contributing to OCA. ❤️ |
Thanks, very interesting topic indeed! |
No description provided.