Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] delivery_price_product_domain: fix shipping without rule #772

Merged

Conversation

dessanhemrayev
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @solo4games, @CetmixGitDrone,
some modules you are maintaining are being modified, check this out!

@dessanhemrayev dessanhemrayev force-pushed the 14.0-t3285-delivery_price_product_domain-bugfix branch 8 times, most recently from c0cea2f to 6116a42 Compare February 23, 2024 00:32
@rousseldenis rousseldenis added this to the 14.0 milestone Feb 23, 2024
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t3285-delivery_price_product_domain-bugfix branch 5 times, most recently from 170b17d to 5f83211 Compare February 24, 2024 19:35
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok

@rousseldenis what do you say?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@pedrobaeza can we merge?

@pedrobaeza
Copy link
Member

@rousseldenis should confirm

@francesco-ooops
Copy link
Contributor

@rousseldenis does it look good for you? thanks!

@dessanhemrayev dessanhemrayev force-pushed the 14.0-t3285-delivery_price_product_domain-bugfix branch from cfbe3c7 to 053b398 Compare March 14, 2024 18:14
@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-772-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 15, 2024
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-772-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@francesco-ooops
Copy link
Contributor

@chienandalu as author of https://github.com/OCA/delivery-carrier/tree/14.0/delivery_cttexpress , could you help us understand whether the error in tests is temporary or needs fixing? thanks!

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-772-by-rousseldenis-bump-patch, awaiting test results.

@rousseldenis
Copy link
Contributor

@OCA-git-bot OCA-git-bot merged commit 7400fe2 into OCA:14.0 Mar 15, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c2a5e70. Thanks a lot for contributing to OCA. ❤️

@francesco-ooops
Copy link
Contributor

@francesco-ooops OCA/odoo-community.org#158 (comment)

Thanks, very interesting topic indeed!

@dessanhemrayev dessanhemrayev deleted the 14.0-t3285-delivery_price_product_domain-bugfix branch March 16, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants