Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] partner_delivery_zone #769

Closed

Conversation

pedroguirao
Copy link

No description provided.

sergio-teruel and others added 30 commits February 12, 2024 08:51
[IMP] partner_delivery_zone: Get delivery zone from commercial partner for non delivery contacts
Currently translated at 100.0% (18 of 18 strings)

Translation: delivery-carrier-15.0/delivery-carrier-15.0-partner_delivery_zone
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-partner_delivery_zone/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-partner_delivery_zone
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-partner_delivery_zone/
Currently translated at 100.0% (19 of 19 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-partner_delivery_zone
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-partner_delivery_zone/es/
- Include context keys for avoiding mail operations overhead.
@pedroguirao pedroguirao mentioned this pull request Feb 12, 2024
34 tasks
@pedrobaeza pedrobaeza changed the title 17.0 mig partner delivery zone [17.0][MIG] partner_delivery_zone Feb 12, 2024
@pedrobaeza
Copy link
Member

Please put the proper PR title, as I did. If not, your PR may not be found by others, as the module name is not correctly put.

Check also the CI.

@pedroguirao
Copy link
Author

Ok thanks!

@rousseldenis
Copy link
Contributor

/ocabot migration partner_delivery_zone

@pedrobaeza
Copy link
Member

Please squash the last 3 migration commits together

[MIG] partner_delivery_zone: Migration to 17.0

[MIG] partner_delivery_zone: Migration to 17.0
@pedroguirao pedroguirao force-pushed the 17.0-mig-partner_delivery_zone branch from 40f6f7d to d5b66c5 Compare February 12, 2024 15:44
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include #843

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
Copy link
Contributor

@RodrigoBM RodrigoBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include #858

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
@pilarvargas-tecnativa
Copy link
Contributor

Please include #911

@rousseldenis
Copy link
Contributor

@pedroguirao Thanks for this.

Could you follow migration guide ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#how-to

In fact, migration changes (version number, ...) should appear in migration commit. Thanks

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 8, 2024
@juancarlosonate-tecnativa

@pedroguirao can you look at the comments?

Copy link
Contributor

@flachica flachica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the sale.order filter to readonly property

<field name="inherit_id" ref="sale.view_order_form" />
<field name="arch" type="xml">
<xpath expr="//field[@name='payment_term_id']" position="after">
<field name="delivery_zone_id" readonly="state in ['done', 'cancel']" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="delivery_zone_id" readonly="state in ['done', 'cancel']" />
<field name="delivery_zone_id" readonly="state in ['sale', 'cancel']" />

<xpath expr="//field[@name='company_id']" position="before">
<field
name="delivery_zone_id"
readonly="state in ['done', 'cancel']"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly="state in ['done', 'cancel']"
readonly="state in ['sale', 'cancel']"

@juancarlosonate-tecnativa
Copy link

juancarlosonate-tecnativa commented Feb 27, 2025

supersede #995

@pedrobaeza pedrobaeza closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.