Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] delivery_carrier_return_barcode_pattern: Exclude inactive carriers #767

Merged
merged 1 commit into from
May 11, 2024
Merged

[14.0][IMP] delivery_carrier_return_barcode_pattern: Exclude inactive carriers #767

merged 1 commit into from
May 11, 2024

Conversation

mt-software-de
Copy link
Contributor

@OCA-git-bot
Copy link
Contributor

Hi @mmequignon,
some modules you are maintaining are being modified, check this out!

@mt-software-de mt-software-de mentioned this pull request Feb 7, 2024
Open
mmequignon
mmequignon reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, tiny question

@rousseldenis rousseldenis added this to the 14.0 milestone Mar 12, 2024
@mt-software-de
Copy link
Contributor Author

ping @mmequignon

@jbaudoux
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-767-by-jbaudoux-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 19, 2024
@OCA-git-bot
Merge PR #767 into 14.0
38f72b5 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-767-by-jbaudoux-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@mt-software-de mt-software-de force-pushed the 14-imp-delivery_carrier_return_barcode_pattern branch from 04321fe to 223478b Compare April 15, 2024 22:33
@mt-software-de
Copy link
Contributor Author

@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-767-by-jbaudoux-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@jbaudoux could you retry the merge
there was an error happening with an external api
https://github.com/OCA/delivery-carrier/actions/runs/8339620595/job/22821953901

@dreispt
Copy link
Member

dreispt commented May 11, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-767-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f011469 into OCA:14.0 May 11, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9d259b9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmequignon mmequignon mmequignon left review comments

@TDu TDu TDu approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mt-software-de @OCA-git-bot @jbaudoux @dreispt @TDu @mmequignon @rousseldenis