[16.0][MIG] delivery_multi_destination: Migration to version 16.0 #766

carolinafernandez-tecnativa · 2024-01-25T12:05:57Z

Standard migration to v16
Supersedes [MIG] delivery_multi_destination: Migration to 16.0 #631 due to inactivity/changes requested not attended

================================================== Multiple destinations for the same delivery method ================================================== Module `delivery` in version 8 allows to set different price rules depending on the destination. This is what is called a delivery grid. In version 9, for simplifying delivery methods, Odoo has plained the structure, lowering destinations at delivery method level, and removing delivery grid model. This is not usable when you have different prices according the destination of your delivery. This module restores the same concept, reusing the same model for nesting several "children" delivery methods, one per possible destination. It has been designed to reuse all possible extensions to the base delivery, without the need to create a glue module for having multiple destinations. This module also handles if you're migrating from version 8 and you had `delivery` module installed, to keep the delivery grids. Installation ============ If you installed the module on a version 8 migrated database, some operations will be done for recovering delivery grids. If so, you need to have **openupgradelib** library installed. Configuration ============= To configure delivery methods with multiple destinations: * Go to Inventory > Configuration > Delivery > Delivery Methods * Create or edit an existing record. * Select "Destination type" = "Multiple destinations". * Introduce a line for each destination in the new tab "Destinations" * Lines have priority, so you have to put first the lines with more restricted destinations. Usage ===== * When using the delivery method in a Sales order, delivery address will be used for computing the delivery price according introduced destinations.

OCA Transbot updated translations from Transifex

…#148) * Don't show children carriers on many2one selections * Don't search by default children carriers * Add demo data OCA Transbot updated translations from Transifex

* Standard procedure * README by fragments * Code changed to follow v11 logic * Tests adapted and expanded

Incorrect use of variables

…lements On a multi-destination carrier, that fields shouldn't be shown

…main one When testing available carriers, we must return the main one if one of the children matches, not returning the children itself.

…h multi Handle the step of sending the shipping (triggered on picking validation) for multi destination delivery. This means to manually check for fixing prices (as the implementation doesn't check this part and always take the main carrier price, not the subcarrier one. Test for this use case done, although the rest of the cases are not covered by tests yet.

[UPD] Update delivery_multi_destination.pot [UPD] README.rst

When there is no carrier, destination_type is false and can cause error. In the case, `one` destination_type should be used. delivery_multi_destination 14.0.1.0.1

TT40225

…le carrier with UX TT42837

This reverts commit 0e28544. This ismixing in the same commit other things for a non related problem that has been fixed in a better way in the previous version, so we are reverting it and applying the rest of the patches.

…sed on rules If the destination carrier line is based on rules, the price is not correctly fetched, as it's hardcoded to call `_get_price_available` using picking's carrier, no matter the recordset from which you call it (the self argument). Thus, the only solution to get the proper value is to temporarily replace the carrier on the picking on the calls chain, to restore it before returning. TT42862

… other companies In the context where `carrier.child_ids` is being examined, all existing subdestinations, no matter the company they have, are shown as being in a sudo environment, so we need to filter them out those from other companies. TT43596

chienandalu

An issue I found in a functional test:

I create a multi destination carrier
With a filtered destination subcarrier
Then I go to a sale order with a partner no in the filtered destination
Force choosing that destination in the wizard:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1591, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1618, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 1822, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 42, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 468, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/odoo/models.py", line 6571, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/opt/odoo/odoo/models.py", line 6282, in _onchange_eval
    method_res = method(self)
  File "/opt/odoo/addons/delivery/wizard/choose_delivery_carrier.py", line 32, in _onchange_carrier_id
    vals = self._get_shipment_rate()
  File "/opt/odoo/addons/delivery/wizard/choose_delivery_carrier.py", line 68, in _get_shipment_rate
    if vals.get('success'):
AttributeError: 'NoneType' object has no attribute 'get'

The above server error caused the following client error:
null

rousseldenis · 2024-01-26T08:34:06Z

/ocabot migration delivery_multi_destination

carolinafernandez-tecnativa · 2024-01-31T15:25:23Z

An issue I found in a functional test:

I create a multi destination carrier
With a filtered destination subcarrier
Then I go to a sale order with a partner no in the filtered destination
Force choosing that destination in the wizard:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1591, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1618, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 1822, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 42, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 468, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/odoo/models.py", line 6571, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/opt/odoo/odoo/models.py", line 6282, in _onchange_eval
    method_res = method(self)
  File "/opt/odoo/addons/delivery/wizard/choose_delivery_carrier.py", line 32, in _onchange_carrier_id
    vals = self._get_shipment_rate()
  File "/opt/odoo/addons/delivery/wizard/choose_delivery_carrier.py", line 68, in _get_shipment_rate
    if vals.get('success'):
AttributeError: 'NoneType' object has no attribute 'get'

The above server error caused the following client error:
null

I checked this and now it seems to work correctly, could you please check? Thanks!!

delivery_multi_destination/models/delivery_carrier.py

delivery_multi_destination/tests/test_delivery_multi_destination.py

delivery_multi_destination/models/delivery_carrier.py

pedrobaeza

The dependency of the order of the assigned values is a bit weird, but let's not block this more.

/ocabot merge nobump

OCA-git-bot · 2024-02-08T19:29:05Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-766-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

carolinafernandez-tecnativa · 2024-03-07T21:07:48Z

ping @chienandalu

pedrobaeza · 2024-04-01T18:07:28Z

/ocabot merge nobump

OCA-git-bot · 2024-04-01T18:07:39Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-766-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-04-01T18:14:53Z

Congratulations, your PR was merged at 3ca77a8. Thanks a lot for contributing to OCA. ❤️

pedrobaeza and others added 22 commits January 25, 2024 09:14

[10.0][ADD] delivery_multi_destination

d4435dc

OCA Transbot updated translations from Transifex

[FIX+IMP] delivery_multi_destination: Don't show children + demo (OCA…

bf114e4

…#148) * Don't show children carriers on many2one selections * Don't search by default children carriers * Add demo data OCA Transbot updated translations from Transifex

[MIG] delivery_multi_destination: Migration to 11.0

c1fbe16

* Standard procedure * README by fragments * Code changed to follow v11 logic * Tests adapted and expanded

[MIG] delivery_multi_destination: Migration to 12.0

511b5ba

[FIX] delivery_multi_destination: Fix singleton error

18f6ed1

Incorrect use of variables

[IMP] delivery_multi_destination: Improve view for hiding undesired e…

f89f07a

…lements On a multi-destination carrier, that fields shouldn't be shown

[FIX] delivery_multi_destination: available carriers must return the …

d8ec3a4

…main one When testing available carriers, we must return the main one if one of the children matches, not returning the children itself.

[IMP] delivery_multi_destination: black, isort, prettier

c3e2e00

[MIG] delivery_multi_destination: Migration to v13.0

c8135ba

[UPD] Update delivery_multi_destination.pot [UPD] README.rst

[IMP] delivery_multi_destination: black, isort, prettier

378c929

[MIG] delivery_multi_destination: Migration to 14.0

7130374

[UPD] Update delivery_multi_destination.pot [UPD] README.rst

[FIX] delivery_multi_destination: consider no carrier scenario

f2329b1

When there is no carrier, destination_type is false and can cause error. In the case, `one` destination_type should be used. delivery_multi_destination 14.0.1.0.1

[FIX] delivery_multi_destination: ondelete=cascade + hide field in multi

2f56f04

[MIG] delivery_multi_destination: Migration to 15.0

df3737f

TT40225

[FIX] delivery_multi_destination: Avoid error in creation of a multip…

67bc983

…le carrier with UX TT42837

[FIX] delivery_multi_destination: consider no carrier scenario

f004d90

[MIG] delivery_multi_destination: Migration to 16.0

ab04037

carolinafernandez-tecnativa force-pushed the 16.0-mig-delivery_multi_destination branch 4 times, most recently from 6c102ca to 5314a23 Compare January 25, 2024 14:02

carolinafernandez-tecnativa changed the title ~~16.0 mig delivery multi destination~~ [16.0][MIG] delivery_multi_destination: Migration to version 16.0 Jan 25, 2024

carolinafernandez-tecnativa marked this pull request as ready for review January 25, 2024 14:12

chienandalu suggested changes Jan 26, 2024

View reviewed changes

rousseldenis added needs review migration labels Jan 26, 2024

OCA-git-bot added this to the 16.0 milestone Jan 26, 2024

OCA-git-bot mentioned this pull request Jan 26, 2024

Migration to version 16.0 #534

Open

32 tasks

rousseldenis mentioned this pull request Jan 26, 2024

[MIG] delivery_multi_destination: Migration to 16.0 #631

Closed

carolinafernandez-tecnativa force-pushed the 16.0-mig-delivery_multi_destination branch from 5314a23 to 6f559a9 Compare January 31, 2024 15:17

chienandalu reviewed Jan 31, 2024

View reviewed changes

delivery_multi_destination/models/delivery_carrier.py Outdated Show resolved Hide resolved

pedrobaeza requested changes Feb 8, 2024

View reviewed changes

delivery_multi_destination/models/delivery_carrier.py Outdated Show resolved Hide resolved

delivery_multi_destination/models/delivery_carrier.py Outdated Show resolved Hide resolved

delivery_multi_destination/tests/test_delivery_multi_destination.py Show resolved Hide resolved

carolinafernandez-tecnativa force-pushed the 16.0-mig-delivery_multi_destination branch from 6f559a9 to f7490b0 Compare February 8, 2024 11:26

pedrobaeza reviewed Feb 8, 2024

View reviewed changes

delivery_multi_destination/tests/test_delivery_multi_destination.py Outdated Show resolved Hide resolved

delivery_multi_destination/models/delivery_carrier.py Outdated Show resolved Hide resolved

[16.0][MIG] delivery_multi_destination: Continue Migration

4539c4c

carolinafernandez-tecnativa force-pushed the 16.0-mig-delivery_multi_destination branch from f7490b0 to 4539c4c Compare February 8, 2024 19:23

pedrobaeza approved these changes Feb 8, 2024

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Feb 8, 2024

Merge PR #766 into 16.0

35d1b3d

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Feb 8, 2024

OCA-git-bot merged commit 4b67932 into OCA:16.0 Apr 1, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 1, 2024

pedrobaeza deleted the 16.0-mig-delivery_multi_destination branch April 1, 2024 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] delivery_multi_destination: Migration to version 16.0 #766

[16.0][MIG] delivery_multi_destination: Migration to version 16.0 #766

carolinafernandez-tecnativa commented Jan 25, 2024 •

edited

Loading

chienandalu left a comment

rousseldenis commented Jan 26, 2024

carolinafernandez-tecnativa commented Jan 31, 2024

pedrobaeza left a comment

OCA-git-bot commented Feb 8, 2024

carolinafernandez-tecnativa commented Mar 7, 2024

pedrobaeza commented Apr 1, 2024

OCA-git-bot commented Apr 1, 2024

OCA-git-bot commented Apr 1, 2024

[16.0][MIG] delivery_multi_destination: Migration to version 16.0 #766

[16.0][MIG] delivery_multi_destination: Migration to version 16.0 #766

Conversation

carolinafernandez-tecnativa commented Jan 25, 2024 • edited Loading

chienandalu left a comment

Choose a reason for hiding this comment

rousseldenis commented Jan 26, 2024

carolinafernandez-tecnativa commented Jan 31, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 8, 2024

carolinafernandez-tecnativa commented Mar 7, 2024

pedrobaeza commented Apr 1, 2024

OCA-git-bot commented Apr 1, 2024

OCA-git-bot commented Apr 1, 2024

carolinafernandez-tecnativa commented Jan 25, 2024 •

edited

Loading