Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] delivery_carrier_deposit #764

Merged
merged 46 commits into from
Feb 8, 2024
Merged

[16.0][MIG] delivery_carrier_deposit #764

merged 46 commits into from
Feb 8, 2024

Conversation

clementmbr
Copy link
Member

@clementmbr clementmbr commented Jan 24, 2024 •
edited
Loading

rebase and fix #617

bealdav and others added 30 commits January 24, 2024 15:55
@bealdav @clementmbr
[PORT] delivery_carrier_deposit to v8, wip
a3108aa
@bealdav @clementmbr
[IMP] replace mako by qweb report in delivery_carrier_deposit
d636685
@bealdav @clementmbr
[FIX] report deposit report
5a61b5b
@bealdav @clementmbr
[FIX] upd translat pot
94c6d31
@bealdav @clementmbr
[FIX] report deposit_slip.xml
c44e1f6
@bealdav @clementmbr
[IMP] upd pot
cdc35bc
@bealdav @clementmbr
[FIX] call to report translation
34fd07b
@clementmbr
delivery_carrier_deposit: port to new API
55b2b6a 
Add computed fields for total weight and total number of packages
Small enhancements in view and usability
Small cleanups
@clementmbr
Add XML header
d69c681
@clementmbr
Add weight in form view of stock.quant.package
032eae4 
Better layout of default report for deposit slip
For stock.quant.package, order by id desc to have the latest first
Code cleanup
@clementmbr
Button "Create Shipping Label" should be used when the picking in Don…
b147737 
…e, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready)

Display number of packages on deposit slip
Add weight in tree view of packages
@bealdav @clementmbr
[FIX] copy in deposit.slip
2978060
@bealdav @clementmbr
[FIX] writing package_id field in shipping.label
8424f84
@clementmbr
[Usability] tree view of deposity.slip: blue when draft
b3553d6
@clementmbr
Move module description in README.rst
b9a52a8
@gurneyalex @clementmbr
Add OCA as author of OCA addons
330cdbd 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@bealdav @clementmbr
[ADD] security rule
61f4597
@rschnapka @clementmbr
add and generate initial german translations
89be524
@oca-transbot @clementmbr
OCA Transbot updated translations from Transifex
9337241
@oca-transbot @clementmbr
OCA Transbot updated translations from Transifex
6e2ab7f
@sbidoul @clementmbr
[UPD] prefix versions with 8.0
6bc4195
@oca-transbot @clementmbr
OCA Transbot updated translations from Transifex
26d1ab6
@pedrobaeza @clementmbr
[MIG] Make modules uninstallable
7da098d
@pedrobaeza @clementmbr
[MIG] Rename manifest files
474555b
@hparfr @clementmbr
delivery_carrier_deposit: Migration to 9.0 (#114)
18c3607
@oca-transbot @clementmbr
OCA Transbot updated translations from Transifex
4eaf7e9
@EBII @clementmbr
mig V10
dd6b754
@bealdav @clementmbr
FIX misc details in deposit
bd0f78b
@florian-dacosta @clementmbr
[FIX] Avoid picking deletion when removing a picking from deposit slip
a927dd5
@alexis-via @clementmbr
delivery_carrier_deposit: Fix view
f41288a
@clementmbr clementmbr marked this pull request as ready for review January 24, 2024 20:52
@clementmbr
Copy link
Member Author

clementmbr commented Jan 24, 2024 •
edited
Loading

There are failing tests on existing modules delivery_roulier and delivery_cttexpress that I don't manage to reproduce locally

@florian-dacosta @rousseldenis @chienandalu as I don't know these other modules very well, if you have any suggestions to fix this, I'm interested! Otherwise I'll dive deeper into these modules later...

Thank you!

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_deposit

@rousseldenis
Copy link
Contributor

@clementmbr Could you rebase ?

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 25, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 25, 2024
Open
32 tasks
@clementmbr
Copy link
Member Author

Hi @rousseldenis, I already did a rebase before adding my last commits and there were no new commit on 16.0 since yesterday... So my branch is already rebased and updated.

@florian-dacosta florian-dacosta force-pushed the 16.0-mig-delivery_carrier_deposit branch from 65b38e5 to 068929c Compare January 29, 2024 10:56
@clementmbr @florian-dacosta
[FIX] remove depreciated tree string attribute
0f554d3 
[FIX] test delivery_carrier_deposit
@florian-dacosta florian-dacosta force-pushed the 16.0-mig-delivery_carrier_deposit branch from 068929c to 0f554d3 Compare January 29, 2024 11:24
@florian-dacosta
Copy link
Contributor

Hello, the delivery_cttexpress happens kind of randomly because direct calls are made to their api in tests (which I find extremely annoying...)
I've just fixed the issue linked to delivery_roulier module. Problem came from a "Fake test class" used in roulier and this module with the same name, and registry was not cleaned in this module.

Here, Odoo tests passed but not OCB, because of delivery_cttexpress...
@rousseldenis Is it possible when you can to re-launch the failing tests step only ?

@rousseldenis
Copy link
Contributor

Hello, the delivery_cttexpress happens kind of randomly because direct calls are made to their api in tests (which I find extremely annoying...) I've just fixed the issue linked to delivery_roulier module. Problem came from a "Fake test class" used in roulier and this module with the same name, and registry was not cleaned in this module.

Here, Odoo tests passed but not OCB, because of delivery_cttexpress... @rousseldenis Is it possible when you can to re-launch the failing tests step only ?

@florian-dacosta Done

FYI : OCA/odoo-community.org#131

robinkeunen
robinkeunen approved these changes Feb 8, 2024
View reviewed changes
Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bguillot
Copy link
Contributor

bguillot commented Feb 8, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-764-by-bguillot-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 8, 2024
@OCA-git-bot
Merge PR #764 into 16.0
b68d93d 
Signed-off-by bguillot
@OCA-git-bot
Copy link
Contributor

@bguillot your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-764-by-bguillot-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@bguillot
Copy link
Contributor

bguillot commented Feb 8, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-764-by-bguillot-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf0c710 into OCA:16.0 Feb 8, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 31b6df1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinkeunen robinkeunen robinkeunen approved these changes

@florian-dacosta florian-dacosta florian-dacosta approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.