Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] delivery_driver_stock_picking_batch #759

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[16.0][ADD] delivery_driver_stock_picking_batch #759

merged 1 commit into from
Feb 2, 2024

Conversation

EmilioPascual
Copy link
Contributor

Add drivers in stock picking batch

PR Series: #752 (must be merged before this one)

@Shide @Gelojr @rafaelbn please review.

MT-4427 @moduon

@rafaelbn rafaelbn added this to the 16.0 milestone Jan 8, 2024
Shide
Shide suggested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

suggestion: Add the same domain as the stock.picking

delivery_driver_stock_picking_batch/models/stock_picking_batch.py Outdated
_inherit = "stock.picking.batch"

driver_ids = fields.Many2many(
"res.partner", string="Drivers", compute="_compute_driver_ids", store=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same domain as the stock.picking

Suggested change
"res.partner", string="Drivers", compute="_compute_driver_ids", store=True
"res.partner", string="Drivers", compute="_compute_driver_ids", store=True, domain="[('is_company', '=', False)]",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

@EmilioPascual EmilioPascual force-pushed the 16.0-delivery_driver_stock_picking_batch branch from e3e3e21 to 313f21e Compare January 15, 2024 15:20
fcvalgar
fcvalgar approved these changes Jan 15, 2024 •
edited
Loading
View reviewed changes
@EmilioPascual
Copy link
Contributor Author

https://www.loom.com/share/c53127a53b664a06b2e81c026a27cf88

fcvalgar
fcvalgar approved these changes Jan 16, 2024
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @EmilioPascual

image

image

image

image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Gelojr
Gelojr approved these changes Jan 26, 2024
View reviewed changes
Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @EmilioPascual
LGTM https://www.loom.com/share/a5520ca5fa7f4667be40aa535b40bbf2?sid=1187a7c8-a2a2-42e5-a08f-a252b0f64f7c

@EmilioPascual
Copy link
Contributor Author

@rafaelbn can you review and merge if neccesary?

rafaelbn
rafaelbn approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. thank you! 👍🏼

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-759-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 1, 2024
@OCA-git-bot
Merge PR #759 into 16.0
4daefbd 
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-759-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@EmilioPascual @rafaelbn @Shide
[ADD] delivery_driver_stock_picking_batch
2efef8d 
Add driver to stock picking batch

MT-4427 @moduon

Co-authored-by: Rafael Blasco <8736623+rafaelbn@users.noreply.github.com>
Co-authored-by: Eduardo de Miguel <1162050+Shide@users.noreply.github.com>
@EmilioPascual EmilioPascual force-pushed the 16.0-delivery_driver_stock_picking_batch branch from 313f21e to 2efef8d Compare February 2, 2024 09:49
@EmilioPascual
Copy link
Contributor Author

@rafaelbn I made rebase, please try again 🙏🏻

@rafaelbn
Copy link
Member

rafaelbn commented Feb 2, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-759-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 229def0 into OCA:16.0 Feb 2, 2024
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6df88a6. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-delivery_driver_stock_picking_batch branch February 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shide Shide Shide approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

@Gelojr Gelojr Gelojr approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@EmilioPascual @OCA-git-bot @rafaelbn @Shide @fcvalgar @Gelojr