[14.0][FIX] delivery_postlogistics: fix date computation #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDu
force-pushed
the
14-fix-postlogistics-delivery-fix-date
branch
from
cecf50d to
462da11
Compare
mmequignon
suggested changes
Dec 20, 2023
| ) | ||
|
|
||
| if order_commitment_date: | ||
| order_commitment_dates = [ |
There was a problem hiding this comment.
We have to consider the shipping_policy.
If all at once use max(), if asap use min()
Also, commitment date might be False in some cases. This isn't a mandatory field
>>> max([False, datetime.now()])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: '>' not supported between instances of 'datetime.datetime' and 'bool'edit: I missed the if date in the comprehension list
sebalix
changed the title
|
@TDu What's the status of this ? Could you rebase ? |
If there is multiple commitment dates when creating a picking. Use the date the furthest in the future.
TDu
force-pushed
the
14-fix-postlogistics-delivery-fix-date
branch
from
462da11 to
b254c95
Compare
|
@rousseldenis Rebase done. Status: it is being used, but need to investigate that comment. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is multiple commitment dates when creating a picking. Use the date the furthest in the future.