-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] delivery_schenker #632
Conversation
539ab82
to
d0ef2d2
Compare
code+functional |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@OCA/logistics-maintainers |
d0ef2d2
to
7e0e465
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
If we had a non-zero value that ended up being < 0.01, it would send 0.0 and fail
When returning an error, any call to rate_shipment will completely block the transaction which is undesirable as it is always called when making an order through a website and the end customer gets an error. The expected/correct way of handling this is to return a dict with an appropriate warning
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_schenker Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_schenker/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_schenker Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_schenker/
…volume field for stock.picking
7e0e465
to
0e0fa7e
Compare
@openupgrade.migrate() | ||
def migrate(env, version): | ||
for i in range(1, 23): | ||
xml_id = "delivery_schenker.schenker_packaging_{}".format(str(i).zfill(2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this migration script working as expected? I would have thought this XML-ID doesn't exist anymore in post migration, unless such references are dropped right after the full module upgrade?
/ocabot merge nobump |
On my way to merge this fine PR! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-632-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@dreispt could you try to merge please? |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at e1e0969. Thanks a lot for contributing to OCA. ❤️ |
Migration from 14.0
Added 1abdeaa