Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] delivery_schenker #632

Merged
merged 23 commits into from
Sep 30, 2024
Merged

Conversation

ferran-S73
Copy link
Contributor

Migration from 14.0

Added 1abdeaa

@ferran-S73 ferran-S73 mentioned this pull request Apr 19, 2023
32 tasks
@ferran-S73 ferran-S73 force-pushed the 16.0-im-delivery_schenker branch 2 times, most recently from 539ab82 to d0ef2d2 Compare April 19, 2023 15:23
@hildickethan
Copy link
Member

code+functional

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 20, 2023
@ferran-S73
Copy link
Contributor Author

@OCA/logistics-maintainers

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 3, 2023
@hildickethan hildickethan force-pushed the 16.0-im-delivery_schenker branch from d0ef2d2 to 7e0e465 Compare October 16, 2023 07:37
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024
chienandalu and others added 18 commits February 19, 2024 09:03
If we had a non-zero value that ended up being < 0.01, it would send 0.0 and fail
When returning an error, any call to rate_shipment will completely block the transaction
which is undesirable as it is always called when making an order through a website and the end customer gets an error.
The expected/correct way of handling this is to return a dict with an appropriate warning
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_schenker
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_schenker/
@ferran-S73 ferran-S73 force-pushed the 16.0-im-delivery_schenker branch from 7e0e465 to 0e0fa7e Compare February 19, 2024 08:03
@openupgrade.migrate()
def migrate(env, version):
for i in range(1, 23):
xml_id = "delivery_schenker.schenker_packaging_{}".format(str(i).zfill(2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this migration script working as expected? I would have thought this XML-ID doesn't exist anymore in post migration, unless such references are dropped right after the full module upgrade?

@sebalix sebalix removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 19, 2024
@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-632-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-632-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@ferran-S73
Copy link
Contributor Author

@dreispt could you try to merge please?

@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-632-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6b251a4 into OCA:16.0 Sep 30, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e1e0969. Thanks a lot for contributing to OCA. ❤️

@ferran-S73 ferran-S73 deleted the 16.0-im-delivery_schenker branch September 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved help wanted merged 🎉 needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants