Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] component: remove XML declarations inside HTML files #496

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[FIX] component: remove XML declarations inside HTML files #496

merged 1 commit into from
Feb 12, 2025

Conversation

kafai-lam
Copy link

@kafai-lam kafai-lam commented Dec 13, 2024 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@kafai-lam kafai-lam marked this pull request as ready for review December 13, 2024 05:00
vvrossem
vvrossem approved these changes Jan 21, 2025
View reviewed changes
Copy link

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR 🙏
Would you mind rebasing since #497 is merged and took care of component (but not component_event nor test_component)

@kafai-lam kafai-lam force-pushed the 17.0-component-remove-xml-declarations-in-html branch from 28df46e to 9e99caa Compare January 21, 2025 13:53
@kafai-lam
Copy link
Author

@vvrossem Rebase done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

@kafai-lam thanks for you contrib! Can you please drop the odoo version from the commit?
See guidelines https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@simahawk
Copy link
Contributor

simahawk commented Jan 22, 2025 •
edited
Loading

BTW I find very strange that the readme generator is not removing this line 🤔

https://github.com/OCA/maintainer-tools/blob/master/tools/gen_addon_readme.py#L116

@kafai-lam kafai-lam changed the title [17.0][FIX] component: remove XML declarations inside HTML files [FIX] component: remove XML declarations inside HTML files Feb 11, 2025
@kafai-lam kafai-lam force-pushed the 17.0-component-remove-xml-declarations-in-html branch from 9e99caa to 6c1ac8c Compare February 11, 2025 17:04
@kafai-lam kafai-lam requested a review from SilvioC2C February 11, 2025 17:05
StefanRijnhart
StefanRijnhart approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-496-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6a17eb9. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit f0ea1c4 into OCA:17.0 Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@vvrossem vvrossem vvrossem approved these changes

@yankinmax yankinmax yankinmax approved these changes

@SilvioC2C SilvioC2C SilvioC2C approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kafai-lam @OCA-git-bot @simahawk @StefanRijnhart @vvrossem @yankinmax @SilvioC2C