[18.0][MIG] account_asset_management: Migration to version 18.0 #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-account_asset_management
branch
2 times, most recently
from
fe31f2b to
5376dd8
Compare
|
/ocabot migration account_asset_management |
victoralmau
approved these changes
Feb 5, 2025
|
Update when you can, OCA/reporting-engine#958 has already been merged, thx! |
add asset management modules asset mgt update redo synch asset mgt with recent V7 changes
[UPD] add places arg in assertAlmostEqual tests [UPD] flake clean
…an't be modified if a move is linked with a depriciation line [IMP][account_asset_management] Define FIELDS_AFFETCS_ASSET_MOVE as a set directly
…iods for asset posting
* Fix compute methods dependencies and small optimizations * Rename demo file to test and move it into the right folder
This is now supported natively by Odoo 11.
… multiple assets in invoice
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_asset_management/
Currently translated at 42.0% (108 of 257 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_asset_management/it/
Some users may be allowed to unlink invoices without billing access, but with current code, they are not able, as the asset line check is done without sudo, and other users except billing or higher ones aren't allowed to access to that model. TT49673
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_asset_management/
Currently translated at 100.0% (256 of 256 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_asset_management/it/
Currently translated at 100.0% (256 of 256 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_asset_management Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_asset_management/es_AR/
The Financial Assets report generates an error message where there is an asset without depreciation table. This is ok for most assets but not for those with method_number = 0 which is the case for assets of type 'Land and Buildings'.
When this module is installed, it prevents the cancellation of posted journals. However, in many cases, this action is necessary—for example, in the account_asset_management module. With this commit, the default constraint is applied only in this module's tests or when Odoo is not running in test mode. This approach provides an alternative to avoid marking the module as rebellious.
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-account_asset_management
branch
from
5376dd8 to
eb4a3c2
Compare
Done. I rebased and removed the last commit. Thanks! |
|
@juancarlosonate-tecnativa could you please update your review? |
|
Functional Test
|
I created a PR for V17 to include it as well. Once this PR is merged, I will cherry-pick it to V18. Thanks.
Regarding the second point, I cannot include a PR that is still open and has pending review comments. Once it is merged, it can be forward-ported to V16, V17, and V18 (if merged before, or feel free to ping me to include it). |
|
@carlos-lopez-tecnativa Thanks you for your work. I am waiting for the review after you cherry-pick #2047 into this. |
This PR enables the configuration of salvage value in the asset profile. Users can configure it with a fixed amount or a percentage of the salvage value.
Done, please update your review, thanks |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ddc74d3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
[18.0][MIG] report_xlsx_helper reporting-engine#958
Update translation from
_()toself.env._().Update domain on fields related to
account.account, usingcheck_company=Trueand_check_company_domain = models.check_company_domain_parent_ofto support company branches.Update domain in record rules; the fields are required, so
company=Falseis unnecessary.TT54054
@Tecnativa @pedrobaeza @victoralmau @carlosdauden could you please review this?.