Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][IMP] account_journal_restrict_mode: do not force hash on bank and cash journals #2008

Merged

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Jan 3, 2025

Forcing the hashing of bank and cash journals results in errors when creating bank transactions, due to the commit added in Odoo: odoo/odoo@9740189

We make the restrict mode field computed in order to force the value correctly based on the journal type.

@JordiMForgeFlow JordiMForgeFlow changed the title [IMP] account_journal_restrict_mode: do not force hash on bank and cash journals [18.0[IMP] account_journal_restrict_mode: do not force hash on bank and cash journals Jan 3, 2025
@JordiMForgeFlow JordiMForgeFlow changed the title [18.0[IMP] account_journal_restrict_mode: do not force hash on bank and cash journals [18.0][IMP] account_journal_restrict_mode: do not force hash on bank and cash journals Jan 3, 2025
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-imp-account_journal_restrict_mode branch 2 times, most recently from 38fdf13 to 2c22004 Compare January 3, 2025 13:48
…sh journals

Forcing the hashing of bank and cash journals results in errors when creating bank transactions,
due to the commit added in Odoo: odoo/odoo@9740189
@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-imp-account_journal_restrict_mode branch from 2c22004 to 574bdad Compare March 11, 2025 09:31
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2008-by-AaronHForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 49785cd into OCA:18.0 Mar 11, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2abd726. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-imp-account_journal_restrict_mode branch March 11, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants