[18.0][MIG] account_journal_lock_date: Migration to 18.0 #2007

BhaveshHeliconia · 2025-01-02T04:14:22Z

No description provided.

The test failed on travis (not on a local install) because the admin users if part of the Adviser group. Make sure we have the right group and add a test for that feature too.

- Change in journal the existing 'Lock date' by two dates, the same as in company. - Add a wizard to allows a massive update of those dates for several journals at the same time.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_journal_lock_date Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_journal_lock_date/

Currently translated at 20.0% (4 of 20 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_journal_lock_date Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_journal_lock_date/it/

…vent test errors since odoo/odoo@81aac30 TT33774

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_journal_lock_date Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_journal_lock_date/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/

Currently translated at 100.0% (19 of 19 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/it/

Currently translated at 100.0% (19 of 19 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/ca/

StefanRijnhart

What was the reason to refactor the tests? Was it just to increase coverage or were some of the tests no longer working?

account_journal_lock_date/tests/test_journal_lock_date.py

StefanRijnhart · 2025-02-06T09:43:29Z

/ocabot migration account_journal_lock_date

StefanRijnhart · 2025-02-28T11:46:08Z

Please check test failure:

 2025-02-07 06:37:08,338 255 ERROR odoo odoo.addons.account_journal_lock_date.tests.test_journal_lock_date: ERROR: TestJournalLockDate.test_journal_lock_date
Traceback (most recent call last):
  File "/__w/account-financial-tools/account-financial-tools/account_journal_lock_date/tests/test_journal_lock_date.py", line 129, in test_journal_lock_date
    move2.with_context(check_move_sequence_no_gap=False).action_post()
  File "/opt/odoo/addons/account/models/account_move.py", line 5192, in action_post
    self._post(soft=False)
Error: Errors detected in log.
  File "/__w/account-financial-tools/account-financial-tools/account_fiscal_position_vat_check/models/account_move.py", line 36, in _post
    return super()._post(soft=soft)
  File "/__w/account-financial-tools/account-financial-tools/account_move_post_date_user/models/account_move.py", line 11, in _post
    res = super()._post(soft)
  File "/__w/account-financial-tools/account-financial-tools/account_move_name_sequence/models/account_move.py", line 91, in _post
    return super()._post(soft=soft)
  File "/opt/odoo/addons/account/models/account_move.py", line 4908, in _post
    to_post.write({
  File "/opt/odoo/addons/account/models/account_move.py", line 3253, in write
    self._hash_moves()
  File "/opt/odoo/addons/account/models/account_move.py", line 3841, in _hash_moves
    chains_to_hash = self._get_chains_to_hash(**kwargs)
  File "/opt/odoo/addons/account/models/account_move.py", line 3943, in _get_chains_to_hash
    raise UserError(_(
odoo.exceptions.UserError: An error occurred when computing the inalterability. A gap has been detected in the sequence.

BhaveshHeliconia · 2025-02-28T12:31:54Z

@StefanRijnhart, Thanks for the suggestion.Please Review.

StefanRijnhart · 2025-02-28T12:52:21Z

account_journal_lock_date/tests/test_journal_lock_date.py

+
+        # Use patch as a context manager as you're doing now
+        with patch.object(
+            type(self.account_move_obj), "_get_chains_to_hash", patched_get_chains


Do we really need to patch this method? I'm thinking, assertRaisesRegex famously does not apply a cursor savepoint like assertRaises does (I suggested odoo/odoo#134471 for that). Maybe the error is also prevented by applying a savepoint explicitely on line 74:

with self.assertRaisesRegex( UserError, ".*prior to and inclusive of the lock date.*" ): with self.env.cr.savepoint():

Can you check?

Thanks for adding the savepoint context manager, but I was hoping it could replace the patch above. Did you check if that works?

@StefanRijnhart, i changed as per your suggestions! Thanks.Please Review.

But now the test no longer demonstrates the mechanisms to avoid the checks. Why did you change that?

And please tell me you do not just feed my comments to your AI codebot.

BhaveshHeliconia · 2025-03-03T04:52:08Z

@StefanRijnhart, Please Review.

StefanRijnhart · 2025-03-07T13:47:36Z

I'm sorry, I don't like how large changes to tests appear and then disappear without any clarification, and you did not deny that you were just feeding my comments to an LLM. You're asking for a rereview before tests are green so I'm superseding this with #2048 which IMHO is a more comprehensive migration.

sbidoul and others added 30 commits January 2, 2025 09:39

[ADD] account_journal_lock_date

45e1e64

[FIX] account_journal_lock_date test on travis

a43061f

The test failed on travis (not on a local install) because the admin users if part of the Adviser group. Make sure we have the right group and add a test for that feature too.

OCA Transbot updated translations from Transifex

dac7d97

[UPD] Update account_journal_lock_date.pot

2befb12

[MIG] - account_journal_lock_date migration to 12.0

779dc5e

[IMP] account_journal_lock_date: two dates per journal

7d2181c

- Change in journal the existing 'Lock date' by two dates, the same as in company. - Add a wizard to allows a massive update of those dates for several journals at the same time.

[UPD] Update account_journal_lock_date.pot

2536ce3

[IMP] account_journal_lock_date: black, isort, prettier

75e8bfb

[MIG] account_journal_lock_date: Migration to 13.0

a1df85a

[UPD] Update account_journal_lock_date.pot

5d7082b

[UPD] README.rst

f778a2c

[MIG] account_journal_lock_date: Migration to 14.0

a59bcd5

[UPD] Update account_journal_lock_date.pot

2852924

[UPD] README.rst

fd3664a

[IMP] update dotfiles

869b12a

[FIX] account_journal_lock_date: Add post_install tag in tests to pre…

0be213e

…vent test errors since odoo/odoo@81aac30 TT33774

account_journal_lock_date 14.0.1.0.1

abf96e8

[MIG] account_journal_lock_date: Migration to 15.0

4226ec2

[UPD] Update account_journal_lock_date.pot

078ac0a

[UPD] README.rst

ae47eef

account_journal_lock_date 15.0.1.0.1

e9d48a1

[MIG] account_journal_lock_date: Migration to 16.0

e1fc42d

account_journal_lock_date: no need to inherit write()

c03afed

[UPD] Update account_journal_lock_date.pot

585ed50

[UPD] README.rst

2476e14

OCA-git-bot and others added 6 commits January 2, 2025 09:39

[BOT] post-merge updates

efde486

[IMP] account_journal_lock_date: pre-commit auto fixes

9dc218b

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch from 16ffc18 to 9a720d9 Compare January 2, 2025 05:21

BhaveshHeliconia mentioned this pull request Jan 2, 2025

Migration to version 18.0 #1944

Open

23 tasks

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch 3 times, most recently from 6ce7f06 to 085819e Compare January 15, 2025 09:15

StefanRijnhart reviewed Feb 6, 2025

View reviewed changes

account_journal_lock_date/tests/test_journal_lock_date.py Outdated Show resolved Hide resolved

OCA-git-bot added this to the 18.0 milestone Feb 6, 2025

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch 2 times, most recently from 48d3436 to fea736b Compare February 7, 2025 06:35

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch from fea736b to 67c5f1a Compare February 28, 2025 12:28

BhaveshHeliconia requested a review from StefanRijnhart February 28, 2025 12:32

StefanRijnhart reviewed Feb 28, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch from 67c5f1a to cc49fa7 Compare March 3, 2025 04:48

BhaveshHeliconia requested a review from StefanRijnhart March 3, 2025 04:52

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch 2 times, most recently from 156372c to 5b055b9 Compare March 5, 2025 10:01

[MIG] account_journal_lock_date: Migration to 18.0

7b347f7

BhaveshHeliconia force-pushed the 18.0-mig-account_journal_lock_date branch from 5b055b9 to 7b347f7 Compare March 5, 2025 12:19

StefanRijnhart closed this Mar 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_journal_lock_date: Migration to 18.0 #2007

[18.0][MIG] account_journal_lock_date: Migration to 18.0 #2007

BhaveshHeliconia commented Jan 2, 2025

StefanRijnhart left a comment

StefanRijnhart commented Feb 6, 2025

StefanRijnhart commented Feb 28, 2025

BhaveshHeliconia commented Feb 28, 2025

StefanRijnhart Feb 28, 2025

StefanRijnhart Mar 3, 2025

BhaveshHeliconia Mar 4, 2025

StefanRijnhart Mar 4, 2025

StefanRijnhart Mar 4, 2025

BhaveshHeliconia commented Mar 3, 2025

StefanRijnhart commented Mar 7, 2025

[18.0][MIG] account_journal_lock_date: Migration to 18.0 #2007

[18.0][MIG] account_journal_lock_date: Migration to 18.0 #2007

Conversation

BhaveshHeliconia commented Jan 2, 2025

StefanRijnhart left a comment

Choose a reason for hiding this comment

StefanRijnhart commented Feb 6, 2025

StefanRijnhart commented Feb 28, 2025

BhaveshHeliconia commented Feb 28, 2025

StefanRijnhart Feb 28, 2025

Choose a reason for hiding this comment

StefanRijnhart Mar 3, 2025

Choose a reason for hiding this comment

BhaveshHeliconia Mar 4, 2025

Choose a reason for hiding this comment

StefanRijnhart Mar 4, 2025

Choose a reason for hiding this comment

StefanRijnhart Mar 4, 2025

Choose a reason for hiding this comment

BhaveshHeliconia commented Mar 3, 2025

StefanRijnhart commented Mar 7, 2025