-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][PERF] Improve journal ledger performance with lots of lines #1287
base: 16.0
Are you sure you want to change the base?
Conversation
af5aceb
to
b5a4bd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Thanks a lot for this huge performance improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, LGTM.
b5a4bd5
to
8e76d66
Compare
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better this way, thanks. The only missing thing is to comment in code before all the .id
stuff that this technique is used for avoiding continuous recordset recreation, which affects dramatically the performance on systems with huge amount of journal items. This way, you avoid that in the future someone is tempted to restore the recordset thing.
8e76d66
to
b9e99e5
Compare
Added the comment in the exigibility check |
Improves the performance when obtaining the Journal Ledger with lots of account moves and lines.
For example in a demo database with 475K customer invoices before this changes the report in xlsx format is generated in 1900 seconds. With this changes is generated in 120 seconds