Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 약속 멤버 가능 시간 엔티티 구현 #36

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

0-tae
Copy link
Contributor

@0-tae 0-tae commented Feb 13, 2025

🚀 What’s this PR about?

  • 작업 내용 요약: 약속 멤버 가능 시간 엔티티 구현 하였습니다.
  • 핵심 변경사항: 약속 멤버 가능 시간 엔티티 구현 하였습니다.

🛠️ What’s been done?

  • 주요 변경사항
    • 엔티티 구현

🧪 Testing Details

  • 별도로 테스트 진행하지 않았습니다.

👀 Checkpoints for Reviewers

  • 리뷰 시 확인할 사항:
    • 약속 호스트 선택 시간과 같은 이유로 AppointmentMember가 포함된 패키지에 구성 하였습니다.

🎯 Related Issues

@0-tae 0-tae requested a review from jsoonworld February 13, 2025 07:28
@0-tae 0-tae self-assigned this Feb 13, 2025
@0-tae 0-tae added ✨ feat Something isn't working 🦖 용태 🦖 Further information is requested labels Feb 13, 2025
Comment on lines +22 to +26
@Column
private LocalDateTime appointmentMemberAvailableStartTime;

@Column
private LocalDateTime appointmentMemberAvailableEndTime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분도 약속 호스트 약속 시간에서 언급한 것처럼, 간단한 시작/종료 시간에 대한 검증이 있으면 좋겠다는 생각이 드는데 어떻게 생각하시나요? 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 Time Validator 책임을 맡는 객체를 구현하여 검증 진행하겠습니다!

@0-tae 0-tae merged commit 6091f88 into develop Feb 13, 2025
1 check passed
@0-tae 0-tae deleted the feat/27 branch February 13, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat Something isn't working 🦖 용태 🦖 Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants