[feat] 약속 호스트 선택 시간 엔티티 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0-tae
added
✨ feat
jsoonworld
reviewed
Feb 13, 2025
Comment on lines
+21
to
+25
| @Column | ||
| private LocalDateTime appointmentHostSelectionStartTime; | ||
|
|
||
| @Column | ||
| private LocalDateTime appointmentHostSelectionEndTime; |
There was a problem hiding this comment.
시작 시간과 종료 시간에 대한 간단한 검증은 필요 없을까요?
예를 들어, 시작 시간이 종료 시간보다 이후인지 검증
이런 부분을 고려해 보면 좋을 것 같습니다! 😊
There was a problem hiding this comment.
따로 Time Validator 책임을 맡는 객체를 구현하여 검증 진행하겠습니다🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What’s this PR about?
🛠️ What’s been done?
🧪 Testing Details
👀 Checkpoints for Reviewers
Appointment와 같이 묶어서 넣었는데 어떻게 생각하시나요?🎯 Related Issues