services/cloudflare-dyndns: require that apiTokenFile be an api token #388853
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
jfly
force-pushed
the
cloudflare-api-token-rework
branch
from
d84c825 to
0f66f3b
Compare
jfly
changed the title
Previously, this option was supposed to be a file of the form `CLOUDFLARE_API_TOKEN=...`, which has a few problems: - That's not an api token. It's an env file fit for passing to systemd's `EnvironmentFile` option. The user could typo the variable name, or intentionally/unintentionally include unrelated environment variables. - It's not how secret files usually work in NixOS. Secret files are usually just the secret, and don't leak details about how the secret is passed to the service. - This increases friction for people switching between cloudflare dyndns services, such as `services.cloudflare-dyndns` and `services.cfdyndns`, which both have a `apiToken` option, but (before this change) with different semantics.
jfly
force-pushed
the
cloudflare-api-token-rework
branch
from
0f66f3b to
bf37f5e
Compare
github-actions
bot
added
10.rebuild-darwin: 0
|
Im fine with this change, can you ping me again in 1 week ? I just want to make sure other potential users of the service have time to have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this option was supposed to be a file of the form
CLOUDFLARE_API_TOKEN=..., which has a few problems:EnvironmentFileoption. The user could typo the variable name, or intentionally/unintentionally include unrelated environment variables.services.cloudflare-dyndnsandservices.cfdyndns, which both have aapiTokenoption, but (before this change) with different semantics.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.