Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofimoji-wayland: init #388852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rofimoji-wayland: init #388852

wants to merge 1 commit into from

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Mar 11, 2025

Hi,

On wayland, the rofimoji command is not displaying rofi-wayland correctly, because it subprocess.run(["rofi", ...]).

The workaround is provided in #265122, but a package appearing on https://search.nixos.org/packages?type=packages&query=rofimoji would be more welcoming I think.

cc. @nonetrix @justinlovinger.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nim65s
Copy link
Contributor Author

nim65s commented Mar 11, 2025

NB: the selector argument does not allow to change this at runtime:

$ nix run nixpkgs#rofimoji -- --selector /nix/store/a7m57kdzzw7r3z8vpp6lnql9rcpc80l8-rofi-1.7.8+wayland1/bin/rofi
usage: rofimoji [-h] [--version] [--action [ACTION ...]] [--skin-tone {neutral,light,medium-light,moderate,dark brown,black,ask}] [--files FILE [FILE ...]] [--prompt PROMPT] [--selector-args SELECTOR_ARGS]
                [--max-recent MAX_RECENT] [--no-frecency] [--only-official] [--hidden-descriptions] [--use-icons] [--selector {rofi,wofi,fuzzel,dmenu,tofi,bemenu,wmenu}] [--clipboarder {xsel,xclip,wl-copy}]
                [--typer {xdotool,wtype}] [--keybinding-copy KEYBINDING_COPY] [--keybinding-type KEYBINDING_TYPE] [--keybinding-clipboard KEYBINDING_CLIPBOARD] [--keybinding-unicode KEYBINDING_UNICODE]
                [--keybinding-copy-unicode KEYBINDING_COPY_UNICODE]
rofimoji: error: argument --selector: invalid choice: '/nix/store/a7m57kdzzw7r3z8vpp6lnql9rcpc80l8-rofi-1.7.8+wayland1/bin/rofi' (choose from rofi, wofi, fuzzel, dmenu, tofi, bemenu, wmenu)

Also, maybe we could turn x11Support = false here, I don't have opinions on that.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant