Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 386424 to release 24.11 #388329

Open
wants to merge 1 commit into
base: release-24.11
Choose a base branch
from
Open

Backport 386424 to release 24.11 #388329

wants to merge 1 commit into from
+3 −3

Conversation

erichelgeson
Copy link
Contributor

Fixed cherry-pick of #386424 to 24.11

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@keenanweaver @erichelgeson
heroic-unwrapped: 2.15.2 -> 2.16.0
917aa98 
(cherry picked from commit ba128c8)
@erichelgeson erichelgeson force-pushed the backport-386424-to-release-24.11 branch from 05358e9 to 917aa98 Compare March 10, 2025 00:58
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 10, 2025
@nix-owners nix-owners bot requested a review from aidalgol March 10, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidalgol aidalgol aidalgol approved these changes

Assignees
No one assigned
Labels
6.topic: games 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erichelgeson @aidalgol @keenanweaver