Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrayUtilities: init #385960

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Mar 1, 2025

Important

This PR is based on the following PRs and cannot be merged until they have landed:

TODO(@ConnorBaker):

  • Tests
  • Summarize

There's common functionality throughout Nixpkgs setup hooks which can/should be componentized and made into a rigorous, tested library of functions.

With the push for __structuredAttrs, it makes sense to offer high(er)-level array utilities.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker ConnorBaker self-assigned this Mar 1, 2025
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: testing Tooling for automated testing of packages and modules 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Mar 1, 2025
@doronbehar
Copy link
Contributor

There's common functionality throughout Nixpkgs setup hooks which can/should be componentized and made into a rigorous, tested library of functions.

With the push for __structuredAttrs, it makes sense to offer high(er)-level array utilities.

Could you give please a somewhat simple and self contained example of existing Nixpkgs code that would gain from the changes scattered in these different PRs?

@ConnorBaker ConnorBaker force-pushed the feat/arrayUtilities branch from 40ec963 to 0a22f98 Compare March 10, 2025 19:44
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: testing Tooling for automated testing of packages and modules labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants