WIP: python312Packages.nicegui: update postPatch to fit to changed pyproject.toml #383925
Conversation
The postPatch phase creates an error, documented in NixOS#383920 due to a change in the pyproject.toml upstream. This commit fits the replace string to the existing one.
|
I won't have time in the next few days to check if that change works and is sufficiant to fix the build but you are welcome to use this first step. |
|
(Maybe this is a good time to stop and think about if the postPatch phase is still necessary. I have no clue.) |
|
|
I was able to use this version in a nix-shell but unfortunately upon starting nicegui, I get To reproduce, use the python file import nicegui
print(nicegui.__version__)
nicegui.ui.label("Hello World")
nicegui.ui.run()the nix-shell let
pkgs = import (builtins.fetchGit
url = "https://github.com/belamu/nixpkgs";
ref = "patch-1";
}) {};
in pkgs.mkShell {
packages = with pkgs; [
(python312.withPackages (python-pkgs: with python-pkgs; [
nicegui
]))];}and run And the web ui shows Is the version string boggling it up? For some reason, the v2.11.1 tag code from nicegui has version 2.11.0-dev specified in the pyproject.toml. Either someone forgot to update it, or that's how it should work. Don't know how they "fixed" it in the mypy version. |
|
Indeed: in the publish workflow in. github/workflows, the version is replaced by the tag name: One solution could be to use this postPatch to change the pyproject as it was done until your change with the setuptools line. Maybe there is also something poetry-specific possible. |
this patching is also done in the github workflow for publishing nicegui on pypy. Failing to patch it results in wrong directory names for static files
ofborg
bot
added
the
2.status: merge conflict
|
I've added a postPatch line that fixes the version in the |
|
The version update and removal of the postPatch is already done on master in MR #385669 Hence the merge conflicts shown here in the github GUI. |
The postPatch phase creates an error, documented in #383920 due to a change in the pyproject.toml upstream. This commit fits the replace string to the existing one.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.