bundler: 2.5.22 -> 2.6.2 #377415
Open
bundler: 2.5.22 -> 2.6.2 #377415
+1,113
−1,002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
this breaks something like this will do #356159 |
blocking updates is IMHO not the way to go, you should resolve the root cause in gitlab code: #353632 (comment) |
liberodark
force-pushed
the
bundler
branch
2 times, most recently
from
9ce24a7 to
d32237d
Compare
it is preferred to fix the root cause, but unti that is done, breaking changes will block updates, otherwise they get reverted again
we can/should add |
@kirillrdy |
the root cause is known, bundler writes it's version into Gemfile.lock, and if version mismatches it refuses to proceed there is no easy solution here, since that check in bundler exists for a good reason. updating them in tandem is not hard, or we can make gitlab bundle own version of bundler. marking gitlab as broken is also not an option. maybe @yayayayaka can suggest something |
kirillrdy
reviewed
Feb 15, 2025
There was a problem hiding this comment.
doesn't build
> Running phase: fixupPhase
> shrinking RPATHs of ELF executables and libraries in /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2
> checking for references to /build/ in /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2...
> gzipping man pages under /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/share/man/
> stripping (with command strip and flags -S -p) in /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/lib /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/bin
> rewriting symlink /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/nix-support/gem-meta/spec to be relative to /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2
> Running phase: installCheckPhase
> Executing versionCheckPhase
> both $pname and $versionCheckProgram are empty, so we don't know which program to run the versionCheckPhase upon
For full logs, run 'nix log /nix/store/c1aknjglajkpa7j9n5kv40x84grnkql7-bundler-2.6.2.drv'.
|
potential fix for gitlab #382196 |
|
thank you @kirillrdy |
|
@liberodark regarding the mentioned build failure, why did you change to nix-update-script? Apparently the old script logic still works? |
GaetanLepage
requested changes
Feb 16, 2025
liberodark
force-pushed
the
bundler
branch
2 times, most recently
from
e8fb80c to
58a6562
Compare
GaetanLepage
approved these changes
Mar 2, 2025
|
cc @anthonyroussel as you are the maintainer of this package. |
|
github-actions
bot
added
6.topic: python
6.topic: nixos
SuperSandro2000
force-pushed
the
bundler
branch
from
32da771 to
811207c
Compare
SuperSandro2000
requested review from
kirillrdy,
SuperSandro2000 and
GaetanLepage
nix-owners
bot
requested review from
doronbehar,
periklis,
nicknovitski,
SuprDewd,
fdns and
bdimcheff
GaetanLepage
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Reviewed @SuperSandro2000 's diff and it is OK to me.
I can try to run nixpkgs-review on x86_64-linux.
kirillrdy
approved these changes
Mar 11, 2025
|
|
@SuperSandro2000 gitlab builds on this branch, but fails on merge with master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix : #372606
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.