-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
albyhub: init at 1.12.0 #368929
base: master
Are you sure you want to change the base?
albyhub: init at 1.12.0 #368929
Conversation
Here's my discovery notes on ldk-node-go, which is "Experimental Go bindings for LDK-node" repository at a glance:
The repository structure includes pre-compiled shared libraries (.so, .dll, .dylib) for different architectures and operating systems. In github.com/getAlby/hub the ldk_node package is imported as follows
Then in github.com/getAlby/hub there's a Dockerfile that essentially runs
It appears that the repository "github.com/getAlby/ldk-node-go" is providing Go bindings for a Rust library called LDK (Lightning Development Kit). Thus, albyhub/ldk-node-go/default.nix is used as a buildinput for albyhub/package.nix |
This comment was marked as outdated.
This comment was marked as outdated.
4793875
to
f30b509
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4936cdb
to
e55c6e2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e3e4277
to
88d0fe1
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5058 |
This comment was marked as outdated.
This comment was marked as outdated.
0fe427c
to
e7b6a37
Compare
810b647
to
a57e322
Compare
#369196
This turns out to be yarn + Go + CGO + shared libraries Nix derivation. Much of this was new territory for me! I used the Dockerfile as a starting point for how this is supposed to be built.
autoPatchelfHook
to clean the RPATHs, but the resulting binary would still have forbidden references to /build/. So to clean the RPATHs I had to add a postInstall step withpatchelf --set-rpath "${lib.makeLibraryPath buildInputs}" $out/bin/http
.Progress:
http
build glalby from sourceglalby is no longer supported and will be removedhttp
toalbyhub
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.