Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] nixos/swapspace: init module #354217

Merged
merged 3 commits into from
Nov 9, 2024
Merged

[Backport release-24.05] nixos/swapspace: init module #354217

merged 3 commits into from
Nov 9, 2024

Conversation

2xsaiko
Copy link
Contributor

@2xsaiko 2xsaiko commented Nov 7, 2024 •
edited
Loading

Backport of #348588 (and the add-maintainer commit from #332765).

Ran the test, seems to be working.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@phanirithvij @2xsaiko
maintainers: add phanirithvij
ee8d166 
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
(cherry picked from commit a538ba0)
@phanirithvij @2xsaiko
nixos/swapspace: init module
f12598e 
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Co-authored-by: Luflosi <luflosi@luflosi.de>
(cherry picked from commit 80ea320)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Nov 7, 2024
@phanirithvij @2xsaiko
nixos/swapspace: add tests
f627c88 
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
(cherry picked from commit e4c898c)
@2xsaiko 2xsaiko force-pushed the backport-348588-to-release-24.05 branch from d27ce16 to f627c88 Compare November 7, 2024 12:23
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 7, 2024
@phanirithvij
Copy link
Member

phanirithvij commented Nov 7, 2024 •
edited
Loading

I doubt we need a backport for this to 24.05 since 24.11 is almost here.

Edit: I concede. I guess 24.05 users can benefit

@phanirithvij
Copy link
Member

@ofborg test swapspace

phanirithvij
phanirithvij approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@phanirithvij phanirithvij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofborg linux tests succeed, swapspace is linux specific.

@Atemu Atemu merged commit bb824c6 into NixOS:release-24.05 Nov 9, 2024
28 of 30 checks passed
@2xsaiko 2xsaiko deleted the backport-348588-to-release-24.05 branch November 11, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanirithvij phanirithvij phanirithvij approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2xsaiko @phanirithvij @Atemu