Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfssl: 5.7.2 -> 5.7.4 #351402

Merged
merged 1 commit into from
Nov 16, 2024
Merged

wolfssl: 5.7.2 -> 5.7.4 #351402

merged 1 commit into from
Nov 16, 2024

Conversation

vifino
Copy link
Member

@vifino vifino commented Oct 26, 2024

Changelog: https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.4-stable

Lots of fixes, including making it fully functional on x86 hosts with only partial AVX2 support, like some VMs/VPSes or certain low-spec Intel CPUs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from fabaff October 26, 2024 11:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Oct 26, 2024
@symphorien
Copy link
Member

ofborg aarch64-linux failure sounds suspect

@vifino vifino marked this pull request as draft November 2, 2024 10:07
@vifino vifino force-pushed the wolfssl-5.7.4 branch 2 times, most recently from 8b7528f to 068e272 Compare November 15, 2024 11:43
@vifino vifino marked this pull request as ready for review November 15, 2024 12:01
@symphorien symphorien merged commit 6664a9d into NixOS:master Nov 16, 2024
34 of 35 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-351402-to-release-24.05 origin/release-24.05
cd .worktree/backport-351402-to-release-24.05
git switch --create backport-351402-to-release-24.05
git cherry-pick -x 61fd228ac959cd231b3aa768e26d15f6c3a01ac4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants