Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/oh my fish install #296575

Closed
wants to merge 980 commits into from

Conversation

hugolgst
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

a-n-n-a-l-e-e and others added 30 commits March 16, 2024 07:58
python311Packages.arviz: 0.17.0 -> 0.17.1
minio: 2024-03-07T00-43-48Z -> 2024-03-10T02-53-48Z
Diff: dandavison/delta@0.16.5...0.17.0
Changelog: https://github.com/dandavison/delta/releases/tag/0.17.0
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
…ckages.streamlit

python311Packages.streamlit: 1.32.1 -> 1.32.2
Currently things like `buildLinux { inherit src version; }` fail because of
`callPackage` auto-inserting `kernelPatches`, which is both a `buildLinux`
argument and a `pkgs` toplevel attribute, with completely different semantics.

Avoid that entirely by splitting the call into two - one for arguments we want
from `callPackage`, and one for everything else.
see: djpohly/dwl@58d33b7 and the project is no archived on github

new source location is: https://codeberg.org/dwl/dwl

Signed-off-by: Maximilian Huber <gh@maxhbr.de>
wl-clipboard-rs: 0.8.0-unstable-2023-11-27 -> 0.8.1
…ckages.langchain-core

python311Packages.langchain-core: 0.1.31 -> 0.1.32
nixos/komga: add service hardening and misc format changes.
…ckages.langsmith

python312Packages.langsmith: 0.1.23 -> 0.1.26
grafana: 10.3.3 -> 10.4.0, explicitly declare subPackages, halve build time, reduce closure size by ~11.5%
nixos/amazon-image: Enable Amazon SSM Agent by default
Co-authored-by: Shawn8901 <huntdionysos@gmx.net>
This sets a standard for Steam compat tools in NixOS where they must have the
compat tool in a special steamcompattool output.

proton-ge-bin was adjusted to conform with it.
This makes it possible to introspect steam-specific arguments such as extraEnv.
Simply use fetchzip and create a symlink to the src rather than unpacking
manually.
This package should never be added to systemPackages or other global
environments as it will not provide any function there. Making its $out a file
will prevent buildEnv from including it; providing an error like this:

error: The store path /nix/store/wxl3m27dmjjsfqvzzxw7ibr0gr54wwkp-proton-ge-bin-GE-Proton9-1 is a file and can't be merged into an environment using pkgs.buildEnv! at /nix/store/ndhb3bsaf3zc6gx22vjl0w11sxvapf7b-builder.pl line 122.

Some breadcrumbs are left inside the file.
@drupol drupol removed 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: policy discussion 6.topic: vim 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: mate The MATE Desktop Environment 6.topic: vscode 6.topic: php labels Mar 17, 2024
@drupol
Copy link
Contributor

drupol commented Mar 17, 2024

It looks like you accidentally mass-pinged a bunch of people, which are now subscribed
and getting notifications for everything in this pull request. Unfortunately, they
cannot be automatically unsubscribed from the issue (removing review request does not
unsubscribe), therefore development cannot continue in this pull request anymore.

Please create a new pull request, link back to this one and ping the
people actually involved in here over there. For the next time, remember to set your PR to draft status before rebasing. In draft status, you can preview the list of maintainers that are about to be requested for review, which allows you to sidestep this issue.

In order to avoid this in the future, there are instructions for how to properly
rebase between branches in our contribution guidelines.
Setting your pull request to draft prior to rebasing is strongly recommended.
In draft status, you can preview the list of people that are about to be requested
for review, which allows you to sidestep this issue.
This is not a bulletproof method, though, as OfBorg still does review requests even on draft PRs.

@hugolgst hugolgst deleted the fix/oh-my-fish-install branch March 17, 2024 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.