Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinegar: 1.6.1 -> 1.7.3 + update sigregrevert patch #289310

Closed
wants to merge 2 commits into from
Closed

Vinegar: 1.6.1 -> 1.7.3 + update sigregrevert patch #289310

wants to merge 2 commits into from

Conversation

ryze312
Copy link
Contributor

@ryze312 ryze312 commented Feb 16, 2024

Description of changes

Updated to latest version using new patch from Flatpak package

Changelog 1.7.0
Changelog 1.7.1
Changelog 1.7.2
Changelog 1.7.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ryze312
Copy link
Contributor Author

ryze312 commented Feb 16, 2024

Flatpak repo also has a few other patches. Why are these not applied too?

@ofborg ofborg bot requested a review from nyabinary February 16, 2024 16:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 16, 2024
@nyabinary
Copy link
Contributor

Flatpak repo also has a few other patches. Why are these not applied too?

Didn't apply cleanly to the wine version nixpkgs has, also you might want to checkout the Vinegar discord and the thread Vinegar on NixOS and this PR too: #289265

@ryze312
Copy link
Contributor Author

ryze312 commented Feb 17, 2024

I suppose this PR can be closed in favor of the other one?

@nyabinary
Copy link
Contributor

I suppose this PR can be closed in favor of the other one?

yep :3

@ryze312 ryze312 closed this Feb 21, 2024
@ryze312 ryze312 deleted the vinegar_segregrevert_update branch February 21, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants