-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grocy: 4.0.3 -> 4.1.0 #288602
grocy: 4.0.3 -> 4.1.0 #288602
Conversation
I updated the ref but the "No channel PR" Job didn't re-run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running phase: patchPhase
applying patch /nix/store/8h2qqpp7gxahrglqchs20l7kdr8lsy9k-0001-Define-configs-with-env-vars.patch
patching file app.php
Hunk #1 FAILED at 12 (different line endings).
Hunk #2 FAILED at 64 (different line endings).
Hunk #3 FAILED at 106 (different line endings).
3 out of 3 hunks FAILED -- saving rejects to file app.php.rej
patching file services/DatabaseService.php
Hunk #1 succeeded at 137 (offset 12 lines).
patching file services/FilesService.php
Hunk #1 FAILED at 10 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file services/FilesService.php.rej
patching file services/StockService.php
Hunk #1 FAILED at 1761.
1 out of 1 hunk FAILED -- saving rejects to file services/StockService.php.rej
error: builder for '/nix/store/8hwcg76i60hcz8sdhir8lj8mhhdwba8a-grocy-4.1.0.drv' failed with exit code 1;
Once you push an updated commit (preferably with the above issue fixed 😆 ) the GHA "No channel PR" check should succeed. |
I know, but the workflow should re-run if the target branch is changed. |
creating dos patch files is pain on my system (or I'm just not experienced in it), lets see if this works |
nope didn't work. |
It can now be built from sources using the PHP/Composer builder! |
I am overwhelmed with being unable to build this myself, hopefully someone can do that and make a PR to get this out! |
The adjusted patch have been taken from NixOS#288602. Changes: https://github.com/grocy/grocy/releases/tag/v4.1.0 https://github.com/grocy/grocy/releases/tag/v4.2.0
Description of changes
https://github.com/grocy/grocy/releases/tag/v4.1.0
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.