Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grocy: 4.0.3 -> 4.1.0 #288602

Closed
wants to merge 1 commit into from
Closed

grocy: 4.0.3 -> 4.1.0 #288602

wants to merge 1 commit into from

Conversation

tebriel
Copy link
Contributor

@tebriel tebriel commented Feb 13, 2024

Description of changes

https://github.com/grocy/grocy/releases/tag/v4.1.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tebriel tebriel changed the base branch from nixos-unstable to master February 13, 2024 16:50
@tebriel
Copy link
Contributor Author

tebriel commented Feb 13, 2024

I updated the ref but the "No channel PR" Job didn't re-run.

@ofborg ofborg bot requested a review from n0emis February 13, 2024 17:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 13, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 13, 2024
@dotlambda
Copy link
Member

I updated the ref but the "No channel PR" Job didn't re-run.

@zimbatm @Mic92 @cole-h @zowoq That should be fixed.

@ofborg eval

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running phase: patchPhase
applying patch /nix/store/8h2qqpp7gxahrglqchs20l7kdr8lsy9k-0001-Define-configs-with-env-vars.patch
patching file app.php
Hunk #1 FAILED at 12 (different line endings).
Hunk #2 FAILED at 64 (different line endings).
Hunk #3 FAILED at 106 (different line endings).
3 out of 3 hunks FAILED -- saving rejects to file app.php.rej
patching file services/DatabaseService.php
Hunk #1 succeeded at 137 (offset 12 lines).
patching file services/FilesService.php
Hunk #1 FAILED at 10 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file services/FilesService.php.rej
patching file services/StockService.php
Hunk #1 FAILED at 1761.
1 out of 1 hunk FAILED -- saving rejects to file services/StockService.php.rej
error: builder for '/nix/store/8hwcg76i60hcz8sdhir8lj8mhhdwba8a-grocy-4.1.0.drv' failed with exit code 1;

@cole-h
Copy link
Member

cole-h commented Feb 13, 2024

Once you push an updated commit (preferably with the above issue fixed 😆 ) the GHA "No channel PR" check should succeed.

@dotlambda
Copy link
Member

Once you push an updated commit (preferably with the above issue fixed 😆 ) the GHA "No channel PR" check should succeed.

I know, but the workflow should re-run if the target branch is changed.

@tebriel
Copy link
Contributor Author

tebriel commented Feb 14, 2024

creating dos patch files is pain on my system (or I'm just not experienced in it), lets see if this works

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 14, 2024
@tebriel
Copy link
Contributor Author

tebriel commented Feb 14, 2024

nope didn't work.

@drupol
Copy link
Contributor

drupol commented Mar 2, 2024

It can now be built from sources using the PHP/Composer builder!

@tebriel
Copy link
Contributor Author

tebriel commented Mar 4, 2024

It can now be built from sources using the PHP/Composer builder!

I am overwhelmed with being unable to build this myself, hopefully someone can do that and make a PR to get this out!

@tebriel tebriel closed this Mar 4, 2024
@tebriel tebriel deleted the patch-1 branch March 4, 2024 15:36
LeSuisse added a commit to LeSuisse/nixpkgs that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants