Apply suggestions from code review

Co-authored-by: Luflosi <luflosi@luflosi.de>
NixOS · Oct 19, 2024 · 12b3126 · 12b3126
1 parent 60fb16b
commit 12b3126
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/nixos/modules/services/system/swapspace.nix b/nixos/modules/services/system/swapspace.nix
@@ -2,6 +2,7 @@
   config,
   lib,
   pkgs,
+  utils,
   ...
 }:
 let
@@ -19,9 +20,9 @@ in
     enable = mkEnableOption "Swapspace, a dynamic swap space manager";
     package = mkPackageOption pkgs "swapspace" { };
     extraArgs = mkOption {
-      type = types.str;
-      default = "";
-      example = "-P -v";
+      type = types.listOf types.str;
+      default = [];
+      example = [ "-P" "-v" ];
       description = "Any extra arguments to pass to swapspace";
     };
     settings = mkOption {
@@ -104,7 +105,7 @@ in
       documentation = [ "man:swapspace(8)" ];
       description = "Swapspace, a dynamic swap space manager";
       serviceConfig = {
-        ExecStart = "${lib.getExe cfg.package} -c ${configFile} ${cfg.extraArgs}";
+        ExecStart = "${lib.getExe cfg.package} -c ${configFile} ${utils.escapeSystemdExecArgs cfg.extraArgs}";
       };
     };
   };