Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bossmod as a combat option #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jaksuhn
Copy link

@Jaksuhn Jaksuhn commented Feb 1, 2025

The set/clear calls are specifically outside of HandleCombat because that running every tick defeats the benefits of having the autorot on the for the entire duration (e.g. quick targeting a second mob and using ogcds on it)

Copy link

semanticdiff-com bot commented Feb 1, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  Battlevest/Data/Config.cs  0% smaller
  Battlevest/Gui/MainWindow.cs  0% smaller
  Battlevest/Services/!ServiceManager.cs  0% smaller
  Battlevest/Services/BossModIPC.cs  0% smaller
  Battlevest/Services/Core.cs  0% smaller

@Limiana
Copy link
Collaborator

Limiana commented Feb 1, 2025

So the problem with BossMod was that it would attempt to attack mobs every game tick.
But, Battlevest has a logic - if "out of los" error is detected, it will mark this mob as "melee only" for few seconds. If during this window another "out of los" error happens, Battlevest will blacklist this mob for some time. And since VBM will keep trying to attack it every frame, it will endlessly trigger these errors and put the mob into infinite blacklist

@Jaksuhn
Copy link
Author

Jaksuhn commented Feb 1, 2025

Hm, well every time I've run BV it's been with vbm turned on the whole time (cause of the aforementioned gains by quick using ogcds on whatever BV targets) and I can't say I've had any problems, but admittedly I've only ever done the same leves (east shroud) on the same class (mch). Guess it would need further testing

@Limiana
Copy link
Collaborator

Limiana commented Feb 1, 2025

Possible solution is to temporarily disable vbm upon encountering error and until position has been changed. I'll check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants