Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/250 링크 하이라이팅 #251

Merged
merged 7 commits into from
May 28, 2024
Merged

Feature/250 링크 하이라이팅 #251

merged 7 commits into from
May 28, 2024

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented May 20, 2024

Issue

작업 내용

  • 링크 하이라이팅 및 연결

@HamBP HamBP self-assigned this May 20, 2024
@HamBP HamBP added the feat 새로운 기능 label May 20, 2024
@HamBP HamBP added this to the show detail milestone May 20, 2024
@HamBP HamBP marked this pull request as draft May 20, 2024 15:35
Copy link

github-actions bot commented May 20, 2024

Test Results

 9 files   9 suites   0s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit adf9eb5.

♻️ This comment has been updated with latest results.

@HamBP HamBP marked this pull request as ready for review May 22, 2024 10:13
Copy link
Member

@mangbaam mangbaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

style = MaterialTheme.typography.bodyLarge.copy(color = Grey30),
)
) { offset ->
val urlOffset = urlParser.urlOffsets.find { (start, end) -> offset in start..<end }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ 새로운 문법 바로 써버리기

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉 ..으로 한 줄 알았는데 ..< 였네 ㅋㅋㅋㅋ
사실 IDE가 고쳐준 거거등

@HamBP HamBP merged commit 382e3d7 into develop May 28, 2024
2 checks passed
@HamBP HamBP deleted the feature/250 branch July 24, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[공연상세] 하이퍼링크
2 participants