Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Ptr utility to HeapPtr #2588

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rodrigo-pino
Copy link
Contributor

Changed it so that everyone in the future is aware that using Ptr has the inherent cost of a heap allocation

@rodrigo-pino rodrigo-pino force-pushed the rdr/refactor-ptr-to-heap-ptr branch from eed30f2 to 4ed675e Compare March 1, 2025 11:12
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 86.53846% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (c905aaf) to head (4ed675e).

Files with missing lines Patch % Lines
rpc/v6/trace.go 33.33% 2 Missing ⚠️
rpc/v7/trace.go 33.33% 2 Missing ⚠️
rpc/v8/trace.go 33.33% 2 Missing ⚠️
rpc/v7/simulation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2588      +/-   ##
==========================================
- Coverage   73.68%   73.65%   -0.03%     
==========================================
  Files         137      137              
  Lines       16711    16711              
==========================================
- Hits        12313    12308       -5     
- Misses       3536     3540       +4     
- Partials      862      863       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants