Fix VM fee issue due to selection of wrong versioned constants #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
+ Coverage 73.64% 73.67% +0.02%
==========================================
Files 137 137
Lines 16675 16711 +36
==========================================
+ Hits 12280 12311 +31
- Misses 3534 3538 +4
- Partials 861 862 +1 ☔ View full report in Codecov by Sentry. |
Comment on lines
-714
to
+718
| } else if version < StarknetVersion::from_str("0.13.2.1").unwrap() { | ||
| CONSTANTS.get(&"0.13.2".to_string()).unwrap().to_owned() | ||
| } else if version < StarknetVersion::from_str("0.13.3").unwrap() { | ||
| CONSTANTS.get(&"0.13.3".to_string()).unwrap().to_owned() | ||
| CONSTANTS.get(&"0.13.2".to_string()).unwrap().to_owned() | ||
| } else if version < StarknetVersion::from_str("0.13.4").unwrap() { | ||
| CONSTANTS.get(&"0.13.3".to_string()).unwrap().to_owned() | ||
| } else if version < StarknetVersion::from_str("0.13.5").unwrap() { |
There was a problem hiding this comment.
What do you think of having <= comparison so our brains can pick this kind of errors better.
There was a problem hiding this comment.
I think the intended behaviour is: Use 1.3.4 until next version appears. Let me try with >= to see if it works.
rodrigo-pino
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.