fix(rpc): TransactionTrace matches rpc v6 specs

[hudem1]

As agreed, i divide #2563 into 3, one PR for each of the 3 rpc pkgs

Here is the PR for rpcv6 pkg: create rpcv6.TransactionTrace instead of using vm.TransactionTrace

Main modifications:

• TransactionTrace.ExecutionResources matches specs
• TransactionTrace.FunctionInvocation.Events matches specs

Question

The specs say TransactionTrace.FunctionInvocation.Messages.To should be a Felt (currently a string in the code):

type OrderedL2toL1Message struct {
	Order   uint64       `json:"order"`
	From    *felt.Felt   `json:"from_address,omitempty"`
	To      string       `json:"to_address"` // todo: make common.Address after fixing starknet-api EthAddress serialisation
	Payload []*felt.Felt `json:"payload"`
}

Is this todo in the struct still valid ?
I can just re-create the type in v6 and define To as a felt instead but i'm just not sure we wanna keep it as a string even in the vm pkg.

[codecov]

Codecov Report

Attention: Patch coverage is 99.27273% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.18%. Comparing base (50efd33) to head (deafd5c).

Files with missing lines	Patch %	Lines
rpc/v6/trace.go	88.88%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
+ Coverage   73.70%   74.18%   +0.48%     
==========================================
  Files         137      138       +1     
  Lines       16711    16833     +122     
==========================================
+ Hits        12317    12488     +171     
+ Misses       3534     3490      -44     
+ Partials      860      855       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rodrigo-pino]

The code looks real good. I would like to add a real world test. Is this possible? Something that without this commit would cause the old code to fail