Ensure order of delivery for event subscription #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiihann
reviewed
Feb 25, 2025
rpc/v8/subscriptions.go
Outdated
Comment on lines
133
to
135
| headerSub := h.newHeads.SubscribeKeepLast() | ||
| reorgSub := h.reorgs.SubscribeKeepLast() // as per the spec, reorgs are also sent in the events subscription | ||
| pendingSub := h.pendingBlock.SubscribeKeepLast() |
There was a problem hiding this comment.
Some other subscription methods (i.e. subscribeNewHeads, subscribeTransactionStatus, subscribePendingTxs) also rely on these feeds. Do they need to use SubscribeKeepLast as well?
There was a problem hiding this comment.
I think it's likely yes. I plan to get it done for an endpoint (starknet_subscribeEvents) first, then convert it to a reusable form, then use it with other endpoints.
infrmtcs
force-pushed
the
dat/order
branch
2 times, most recently
from
0f01670 to
5892b03
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
==========================================
- Coverage 73.64% 73.62% -0.02%
==========================================
Files 137 137
Lines 16675 16656 -19
==========================================
- Hits 12280 12263 -17
+ Misses 3534 3532 -2
Partials 861 861 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2547