Refactor: Reuse v6 starknet_add-Invoke/DeployAccount/Declare-Transaction handler for v7

[hudem1]

rpc pkg cleanup to #2437

• Fix a little missing validation field for the SenderAddress field inside v6 Transaction type.

• Reuse v6 handler for v7 for starknet_addInvokeTransaction, starknet_addDeployAccountTransaction and starknet_addDeclareTransaction

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (94071e4) to head (fab8d2b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
+ Coverage   73.65%   73.81%   +0.15%     
==========================================
  Files         137      137              
  Lines       16659    16531     -128     
==========================================
- Hits        12271    12203      -68     
+ Misses       3526     3478      -48     
+ Partials      862      850      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rianhughes]

Why can't we delete the v8 AddTransaction method? Is it because we will need to restrict the method to only allow v3 transactions?

[hudem1]

Why can't we delete the v8 AddTransaction method? Is it because we will need to restrict the method to only allow v3 transactions?

Yes this, and there are many other different validations b/w rpc v7 and v8 txs.
And also, v8 tx has the additional variant ResourceL1DataGas for Resource enum.