fix: format error stack for rpc v0.8 #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 137 137
Lines 16711 16711
=======================================
Hits 12317 12317
+ Misses 3534 3531 -3
- Partials 860 863 +3 ☔ View full report in Codecov by Sentry. |
AnkushinDaniil
requested review from
rianhughes and
rodrigo-pino
and removed request for
rodrigo-pino
AnkushinDaniil
force-pushed
the
daniil/add-error
branch
from
3a8a53a to
64b55f8
Compare
AnkushinDaniil
force-pushed
the
daniil/add-error
branch
3 times, most recently
from
7e1b7a8 to
459542c
Compare
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
had a problem deploying
to
Staging
GitHub Actions
Error
AnkushinDaniil
force-pushed
the
daniil/add-error
branch
from
459542c to
ddb47ad
Compare
AnkushinDaniil
temporarily deployed
to
Development
GitHub Actions
Inactive
AnkushinDaniil
had a problem deploying
to
Staging
GitHub Actions
Error
AnkushinDaniil
changed the title
ExecutionError
AnkushinDaniil
added
Bug
AnkushinDaniil
force-pushed
the
daniil/add-error
branch
from
03aea61 to
e773ee5
Compare
AnkushinDaniil
force-pushed
the
daniil/add-error
branch
from
e773ee5 to
0c31e21
Compare
weiihann
approved these changes
Feb 28, 2025
- Introduced `ExecutionError` enum to encapsulate different error types, including `TransactionExecutionError` and `CustomError`. - Added `SimulationError` enum to handle specific simulation-related errors such as `OutOfGas` and `ExecutionError`. - Implemented `fmt::Display` and `From` traits for `ExecutionError` and `SimulationError` to provide meaningful error messages and conversions. - Replaced the use of `anyhow::anyhow!` with structured error handling using the new error types. - Updated `execute_transaction` to use the new `ExecutionError` type. - Refactored `is_l2_gas_accounting_enabled`, `get_gas_vector_computation_mode`, `simulate_execution`, `set_l2_gas_limit`, and `extract_l2_gas_limit` functions to handle errors using the new error types.
rodrigo-pino
force-pushed
the
daniil/add-error
branch
from
6d2b972 to
b265910
Compare
rodrigo-pino
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.