refactor: Reuse v6 starknet_getTransactionByHash handler for v7 #2486
Conversation
There was a problem hiding this comment.
We should also be handling the pending block in v6 in the same way. As far as I know, this difference happened because the old code for v6 was copied in #2419 . You can use the same code from v7 and continue refactoring.
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (47.05%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
==========================================
- Coverage 73.65% 73.54% -0.12%
==========================================
Files 137 137
Lines 16659 16653 -6
==========================================
- Hits 12271 12248 -23
- Misses 3526 3541 +15
- Partials 862 864 +2 ☔ View full report in Codecov by Sentry. |
Ah yes indeed, good catch! I updated v6 code, and I could then reuse v6 handler for v7. |
hudem1
changed the title
rpc/v7/transaction_test.go
Outdated
| }) | ||
| } | ||
|
|
||
| // Convert a v6 transaction object to a v7 transaction object | ||
| func AdaptV6TxToV7(t *testing.T, tx *rpcv6.Transaction) *rpc.Transaction { |
There was a problem hiding this comment.
I think we can un-export this
rpc pkg cleanup according to issue #2437
for v6: Updated handler code to take into account pending block as well.
for v7: Reuse v6 handler for v7 as the logic is the same.
for v8: The logic is the same as v6/v7, but not exactly the returned
Transactiontype (more particularly,Resourcetype insideTransactiontype). Therefore, we cannot refactor v8's types or logic