Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse rpcv6 BlockWithTxHashes for v7 #2449

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 10, 2025

First, please review PRs: #2447 and #2448, as this PR depends on them.

Then,

  1. v7:
  • reuses the same type BlockWithTxHashes struct as v6, so removed it.
  • not exactly same logic even if similar, so can't reuse v6's logic
  1. v8: nothing for it as BlockWithTxHashes struct uses Header struct, which has an additional field. So, can't remove v8's logic to reuse v6's.

@hudem1 hudem1 mentioned this pull request Feb 10, 2025
23 tasks
@hudem1 hudem1 changed the title Reuse fpcv6 BlockWithTxHashes for v7 Reuse rpcv6 BlockWithTxHashes for v7 Feb 10, 2025
@hudem1 hudem1 marked this pull request as ready for review February 14, 2025 15:48
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.79%. Comparing base (0ddfa64) to head (8a13e1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
+ Coverage   73.78%   73.79%   +0.01%     
==========================================
  Files         138      138              
  Lines       16925    16925              
==========================================
+ Hits        12488    12490       +2     
+ Misses       3571     3568       -3     
- Partials      866      867       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rianhughes rianhughes self-requested a review February 24, 2025 13:59
@hudem1 hudem1 requested a review from rodrigo-pino February 26, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants