This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Eliminate mismatch between opset1/opset2 and our real intentions #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added missing ops
GlebKazantaev
approved these changes
Mar 31, 2020
|
We have removed @diyessi from the review as it stuff is not architectural and affects mostly OpenVINO stack. The PR was created yesterday, there hasn't been any feedback from his side since then. We would like to merge it quickly and avoid waiting another day. |
jane-intel
approved these changes
Mar 31, 2020
tomdol
approved these changes
Mar 31, 2020
ilyachur
approved these changes
Mar 31, 2020
jane-intel
pushed a commit
that referenced
this pull request
Apr 5, 2020
* Removed operations from opset2 that were added to opset1 by mistake; added missing ops * Fixed wrong include of opset1 to opset2
silee2
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Export symbols from onnx-import * Fixed for cross-compilation * Eliminate mismatch between opset1/opset2 and our real intentions (#4495) * Removed operations from opset2 that were added to opset1 by mistake; added missing ops * Fixed wrong include of opset1 to opset2 * Trigger CI * Fixed code style * CI triger Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com> Co-authored-by: Sergey Lyalin <sergey.lyalin@intel.com> Co-authored-by: Ilya Churaev <ilya.churaev@intel.com> Co-authored-by: Robert Kimball <robert.kimball@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify opset2 based on our real intentions in forming opset1. Opset1 has some mismatches with what we have in OpenVINO spec. As we cannot modify opset1 as it had been already released, so we apply fixed in opset2.