Resolve PlaybackThread-related errors #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused imports
Add debug logging of queue items
Explicitly stop+join a playback thread that is being discarded
…deprecation before next stable release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to prevent duplicated
PlaybackThreadinstancesPatch out ovos_utils/ovos_workshop deprecation warnings that affect versions currently incompatible with this package
Refactor to implement upstream
synthmethod and drop internal_get_ttsmethodIssues
ovos_audiopossibly closes [BUG] TTS cache #140Other Notes
Resolves observed Mark2 issues where
wait_while_speakingsometimes times out without a response from the Audio service