-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement websocket client class #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to minimize duplicate code
…e determined based on token contents
Read HANA server address from config Read Node username/password from config
Cleanup code to resolve warnings Update bundled configuration
Add changelog updates to automation Cleanup logging
Timeout if WS does not connect
Troubleshoot connection errors
NeonDaniel
added a commit
to NeonGeckoCom/neon-hana
that referenced
this pull request
May 21, 2024
# Description Implements a websocket API for a Node client Adds `ClientPermissions` object to define per-client permissions # Issues Closes #6 # Other Notes Example client implementation: NeonGeckoCom/neon-nodes#14 --------- Co-authored-by: Daniel McKnight <daniel@neon.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a WS communication-based client
Refactor to minimize duplicate code
Issues
Other Notes