-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests #1
Open
yozlet
wants to merge
12
commits into
NathanCastle:main
Choose a base branch
from
yozlet:yozlet/add-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced package.json with dev dependencies for Mocha, Chai, and JSDOM - Added JSDOM setup in tests.js to enable testing in Node.js environment - Updated tests to use JSDOM and improve cross-environment compatibility - Added singleton instance clearing method to substitutionsViewModel - Enhanced test coverage for substitutionsViewModel and fileViewModel
- Added localStorage mock for consistent testing across environments - Updated Mocha setup in test.html with explicit configuration - Enhanced localStorage persistence test for substitutionsViewModel - Simplified localStorage testing approach in tests.js
- Updated test cases to parse more messages from sample Zoom chat - Added test to verify markdown output filters direct messages - Expanded test coverage for fileViewModel parsing logic
- Added test case for additional message in markdown rendering - Improved test for direct message filtering in markdown output - Verified markdown generation excludes direct messages
- Reorganized tests into logical describe blocks for better readability - Added comprehensive HTML rendering tests for fileViewModel - Introduced new test cases for HTML message structure and print view - Removed redundant test cases and consolidated test coverage
- Added global variable comments for browser environment - Implemented Node.js module exports in meet.js - Updated file rendering to use document.createTextNode for safer text insertion - Expanded JSDOM setup in tests.js with more robust configuration - Added FileReader mock for testing - Improved environment-specific initialization checks
Ack, realised that my test data is completely wrong. Hold please... |
- Updated parsing logic to handle multiline messages with consistent formatting - Refined message parsing to better handle "to Everyone" and direct message scenarios - Improved content extraction for messages with multiple lines - Updated test cases to validate new parsing behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add a basic feature or two to the code, but I figured I should start with tests to ensure I don't break anything.
The test suite works in the browser - just open
tests.html
. However they also work on the command line (npm test
)