Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging of OAuth + Connections #3460

Merged
merged 10 commits into from
Mar 9, 2024
Merged

Merging of OAuth + Connections #3460

merged 10 commits into from
Mar 9, 2024

Conversation

partydragen
Copy link
Member

@partydragen partydragen commented Nov 2, 2023 •
edited
Loading

Merge OAuth into connections instead of 2 seperate linking systems making alot of users confused and to not need to link two times on same provider

Aswell to solve current problems releated with connections using oauth for linking aswell
Also its confusing to setup integration that requires oauth for then you need to setup oauth + integration instead of just doing it all in integration page

Progress:

  • Remove OAuth pages
  • Make users login/register using the connections data
  • Add google integration
  • Move OAuth settings to integration setting page instead of squeeze it all into same page and single row
  • Add option to allow user to login/register with the oauth (Currently if you add linking with it it also requires login/register)

@partydragen partydragen marked this pull request as ready for review December 17, 2023 14:59
@partydragen @tadhgboyle
Beginning merging of OAuth2 + Connections
70f746d 
Add Google Integration

Remove oauth language terms

Move OAuth settings to Integration settings

Make OAuth optional for register/login
@tadhgboyle tadhgboyle force-pushed the merge-oauth-connections branch 2 times, most recently from 428aaff to 70f746d Compare December 18, 2023 00:56
@partydragen partydragen changed the title Beginning merging of OAuth + Connections Merging of OAuth + Connections Mar 6, 2024
@partydragen partydragen added this to the 2.2.0 milestone Mar 9, 2024
@samerton samerton merged commit 95d4a44 into develop Mar 9, 2024
14 checks passed
@samerton samerton deleted the merge-oauth-connections branch March 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samerton samerton samerton approved these changes

@tadhgboyle tadhgboyle Awaiting requested review from tadhgboyle

@supercrafter100 supercrafter100 Awaiting requested review from supercrafter100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@partydragen @samerton