Rework counting_iterator difference #3861

bernhardmgruber · 2025-02-19T15:59:50Z

I had this simplification lying around, but I am not entirely sure whether we should include it. It changes behavior for __[u]int128_t (maybe for the better), but may also change behavior for any user-defined integral type (we didn't have tests for this and this PR is also not adding them). This PR is still a simplification.

copy-pr-bot · 2025-02-19T15:59:55Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

bernhardmgruber · 2025-02-19T16:02:50Z

thrust/testing/counting_iterator.cu

+static_assert(diff_type_is<__int128_t, ptrdiff_t>);
+static_assert(diff_type_is<__uint128_t, ptrdiff_t>);


Before the second commit of this PR (the first commit adds this test), the answer was:

static_assert(diff_type_is<__int128_t, __int128_t>); static_assert(diff_type_is<__uint128_t, long>);

Which may be surprising.

thrust/thrust/iterator/counting_iterator.h

miscco

I am fine with custom integer types getting a sane default

github-actions · 2025-03-05T20:36:49Z

🟨 CI finished in 2h 30m: Pass: 98%/93 | Total: 2d 20h | Avg: 44m 20s | Max: 1h 23m | Hits: 48%/133878

🟥 python: Pass: 0%/1 | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s

🟥 cpu
  🟥 amd64              Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 ctk
  🟥 12.8               Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 cudacxx
  🟥 nvcc12.8           Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 cudacxx_family
  🟥 nvcc               Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 cxx
  🟥 GCC13              Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 cxx_family
  🟥 GCC                Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 gpu
  🟥 rtx2080            Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s
🟥 jobs
  🟥 Test               Pass:   0%/1   | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s

🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 24s | Max: 1h 23m | Hits: 35%/53614

🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 16h | Avg: 57m 04s | Max:  1h 23m | Hits:  36%/51178 
  🟩 arm64              Pass: 100%/2   | Total:  2h 09m | Avg:  1h 04m | Max:  1h 04m | Hits:  22%/2436  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  5h 20m | Avg:  1h 04m | Max:  1h 08m | Hits:  20%/5922  
  🟩 12.5               Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
  🟩 12.8               Pass: 100%/38  | Total:  1d 11h | Avg: 55m 46s | Max:  1h 23m | Hits:  38%/45438 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 04m | Hits:  21%/2104  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  5h 20m | Avg:  1h 04m | Max:  1h 08m | Hits:  20%/5922  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
  🟩 nvcc12.8           Pass: 100%/36  | Total:  1d 09h | Avg: 55m 21s | Max:  1h 23m | Hits:  38%/43334 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 04m | Hits:  21%/2104  
  🟩 nvcc               Pass: 100%/43  | Total:  1d 16h | Avg: 57m 07s | Max:  1h 23m | Hits:  35%/51510 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  4h 00m | Avg:  1h 00m | Max:  1h 01m | Hits:  22%/4880  
  🟩 Clang15            Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 03m | Hits:  22%/2436  
  🟩 Clang16            Pass: 100%/2   | Total:  2h 10m | Avg:  1h 05m | Max:  1h 05m | Hits:  22%/2436  
  🟩 Clang17            Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m | Hits:  22%/2436  
  🟩 Clang18            Pass: 100%/7   | Total:  5h 57m | Avg: 51m 04s | Max:  1h 04m | Hits:  45%/8194  
  🟩 GCC7               Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 08m | Hits:  22%/2440  
  🟩 GCC8               Pass: 100%/1   | Total:  1h 14m | Avg:  1h 14m | Max:  1h 14m | Hits:  22%/1220  
  🟩 GCC9               Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 03m | Hits:  22%/2440  
  🟩 GCC10              Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 02m | Hits:  22%/2440  
  🟩 GCC11              Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 08m | Hits:  22%/2436  
  🟩 GCC12              Pass: 100%/2   | Total:  2h 13m | Avg:  1h 06m | Max:  1h 06m | Hits:  22%/2436  
  🟩 GCC13              Pass: 100%/11  | Total:  7h 24m | Avg: 40m 25s | Max:  1h 22m | Hits:  64%/13398 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 26m | Avg:  1h 13m | Max:  1h 19m | Hits:  12%/2084  
  🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 41m | Avg:  1h 20m | Max:  1h 23m | Hits:  12%/2084  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total: 16h 12m | Avg: 57m 12s | Max:  1h 05m | Hits:  31%/20382 
  🟩 GCC                Pass: 100%/22  | Total: 19h 18m | Avg: 52m 39s | Max:  1h 22m | Hits:  43%/26810 
  🟩 MSVC               Pass: 100%/4   | Total:  5h 08m | Avg:  1h 17m | Max:  1h 23m | Hits:  12%/4168  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
🟩 gpu
  🟩 h100               Pass: 100%/3   | Total:  1h 18m | Avg: 26m 00s | Max: 31m 16s | Hits:  73%/3654  
  🟩 rtx2080            Pass: 100%/34  | Total:  1d 13h | Avg:  1h 06m | Max:  1h 23m | Hits:  21%/40216 
  🟩 rtxa6000           Pass: 100%/8   | Total:  4h 21m | Avg: 32m 37s | Max:  1h 07m | Hits:  80%/9744  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  1d 16h | Avg:  1h 05m | Max:  1h 23m | Hits:  21%/43870 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 22m 39s | Avg: 22m 39s | Max: 22m 39s | Hits:  99%/1218  
  🟩 GraphCapture       Pass: 100%/1   | Total: 17m 30s | Avg: 17m 30s | Max: 17m 30s | Hits:  99%/1218  
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 09m | Avg: 23m 03s | Max: 23m 56s | Hits:  99%/3654  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 07m | Avg: 22m 39s | Max: 23m 29s | Hits:  99%/3654  
🟩 sm
  🟩 90                 Pass: 100%/3   | Total:  1h 18m | Avg: 26m 00s | Max: 31m 16s | Hits:  73%/3654  
  🟩 90;90a;100         Pass: 100%/1   | Total:  1h 22m | Avg:  1h 22m | Max:  1h 22m | Hits:  22%/1218  
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 21h 59m | Avg:  1h 05m | Max:  1h 23m | Hits:  20%/23591 
  🟩 20                 Pass: 100%/25  | Total: 21h 03m | Avg: 50m 33s | Max:  1h 22m | Hits:  46%/30023

🟩 thrust: Pass: 100%/45 | Total: 1d 01h | Avg: 33m 29s | Max: 1h 09m | Hits: 57%/79956

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 40m 11s | Avg: 20m 05s | Max: 29m 35s | Hits:  74%/3556  
🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 00h | Avg: 33m 38s | Max:  1h 09m | Hits:  57%/76401 
  🟩 arm64              Pass: 100%/2   | Total:  1h 00m | Avg: 30m 16s | Max: 31m 48s | Hits:  50%/3555  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 15m | Avg: 39m 03s | Max:  1h 07m | Hits:  47%/8881  
  🟩 12.5               Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
  🟩 12.8               Pass: 100%/38  | Total: 19h 48m | Avg: 31m 16s | Max:  1h 09m | Hits:  60%/67521 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 53m 53s | Avg: 26m 56s | Max: 26m 59s | Hits:  50%/3554  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 15m | Avg: 39m 03s | Max:  1h 07m | Hits:  47%/8881  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
  🟩 nvcc12.8           Pass: 100%/36  | Total: 18h 54m | Avg: 31m 30s | Max:  1h 09m | Hits:  60%/63967 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 53m 53s | Avg: 26m 56s | Max: 26m 59s | Hits:  50%/3554  
  🟩 nvcc               Pass: 100%/43  | Total:  1d 00h | Avg: 33m 48s | Max:  1h 09m | Hits:  57%/76402 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 08m | Avg: 32m 10s | Max: 32m 41s | Hits:  57%/7108  
  🟩 Clang15            Pass: 100%/2   | Total:  1h 05m | Avg: 32m 42s | Max: 35m 21s | Hits:  50%/3554  
  🟩 Clang16            Pass: 100%/2   | Total:  1h 13m | Avg: 36m 48s | Max: 38m 42s | Hits:  50%/3554  
  🟩 Clang17            Pass: 100%/2   | Total:  1h 08m | Avg: 34m 01s | Max: 35m 53s | Hits:  50%/3554  
  🟩 Clang18            Pass: 100%/7   | Total:  2h 41m | Avg: 23m 05s | Max: 30m 56s | Hits:  65%/12439 
  🟩 GCC7               Pass: 100%/2   | Total:  1h 02m | Avg: 31m 20s | Max: 31m 57s | Hits:  62%/3556  
  🟩 GCC8               Pass: 100%/1   | Total: 31m 44s | Avg: 31m 44s | Max: 31m 44s | Hits:  50%/1778  
  🟩 GCC9               Pass: 100%/2   | Total:  1h 06m | Avg: 33m 12s | Max: 33m 18s | Hits:  58%/3556  
  🟩 GCC10              Pass: 100%/2   | Total:  1h 06m | Avg: 33m 22s | Max: 34m 09s | Hits:  50%/3556  
  🟩 GCC11              Pass: 100%/2   | Total:  1h 06m | Avg: 33m 09s | Max: 34m 25s | Hits:  50%/3556  
  🟩 GCC12              Pass: 100%/2   | Total:  1h 08m | Avg: 34m 13s | Max: 35m 22s | Hits:  50%/3556  
  🟩 GCC13              Pass: 100%/10  | Total:  3h 35m | Avg: 21m 32s | Max: 33m 11s | Hits:  75%/17780 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 07m | Hits:  30%/3542  
  🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 53m | Avg: 57m 50s | Max:  1h 09m | Hits:  40%/5313  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  8h 17m | Avg: 29m 15s | Max: 38m 42s | Hits:  58%/30209 
  🟩 GCC                Pass: 100%/21  | Total:  9h 37m | Avg: 27m 30s | Max: 35m 22s | Hits:  64%/37338 
  🟩 MSVC               Pass: 100%/5   | Total:  5h 08m | Avg:  1h 01m | Max:  1h 09m | Hits:  36%/8855  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 31m 30s | Avg: 15m 45s | Max: 20m 30s | Hits:  75%/3556  
  🟩 rtx2080            Pass: 100%/33  | Total: 20h 34m | Avg: 37m 23s | Max:  1h 08m | Hits:  50%/58637 
  🟩 rtx4090            Pass: 100%/10  | Total:  4h 01m | Avg: 24m 11s | Max:  1h 09m | Hits:  77%/17763 
🟩 jobs
  🟩 Build              Pass: 100%/38  | Total: 23h 34m | Avg: 37m 13s | Max:  1h 09m | Hits:  50%/67519 
  🟩 TestCPU            Pass: 100%/3   | Total: 50m 16s | Avg: 16m 45s | Max: 35m 07s | Hits:  90%/5326  
  🟩 TestGPU            Pass: 100%/4   | Total: 42m 53s | Avg: 10m 43s | Max: 11m 00s | Hits:  99%/7111  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 31m 30s | Avg: 15m 45s | Max: 20m 30s | Hits:  75%/3556  
  🟩 90;90a;100         Pass: 100%/1   | Total: 30m 33s | Avg: 30m 33s | Max: 30m 33s | Hits:  76%/1778  
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 13h 13m | Avg: 39m 39s | Max:  1h 08m | Hits:  49%/35531 
  🟩 20                 Pass: 100%/23  | Total: 11h 14m | Avg: 29m 18s | Max:  1h 09m | Hits:  63%/40869

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 10s | Avg: 8m 05s | Max: 13m 34s | Hits: 97%/308

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 36s | Avg:  2m 36s | Max:  2m 36s | Hits:  95%/154   
  🟩 Test               Pass: 100%/1   | Total: 13m 34s | Avg: 13m 34s | Max: 13m 34s | Hits:  98%/154

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
+/-	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 93)

#	Runner
66	`linux-amd64-cpu16`
9	`windows-amd64-cpu16`
6	`linux-amd64-gpu-rtxa6000-latest-1`
4	`linux-arm64-cpu16`
3	`linux-amd64-gpu-h100-latest-1`
3	`linux-amd64-gpu-rtx4090-latest-1`
2	`linux-amd64-gpu-rtx2080-latest-1`

github-actions · 2025-03-05T21:51:07Z

🟩 CI finished in 3h 45m: Pass: 100%/93 | Total: 2d 21h | Avg: 44m 48s | Max: 1h 23m | Hits: 48%/133878

🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 24s | Max: 1h 23m | Hits: 35%/53614

🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 16h | Avg: 57m 04s | Max:  1h 23m | Hits:  36%/51178 
  🟩 arm64              Pass: 100%/2   | Total:  2h 09m | Avg:  1h 04m | Max:  1h 04m | Hits:  22%/2436  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  5h 20m | Avg:  1h 04m | Max:  1h 08m | Hits:  20%/5922  
  🟩 12.5               Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
  🟩 12.8               Pass: 100%/38  | Total:  1d 11h | Avg: 55m 46s | Max:  1h 23m | Hits:  38%/45438 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 04m | Hits:  21%/2104  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  5h 20m | Avg:  1h 04m | Max:  1h 08m | Hits:  20%/5922  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
  🟩 nvcc12.8           Pass: 100%/36  | Total:  1d 09h | Avg: 55m 21s | Max:  1h 23m | Hits:  38%/43334 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 04m | Hits:  21%/2104  
  🟩 nvcc               Pass: 100%/43  | Total:  1d 16h | Avg: 57m 07s | Max:  1h 23m | Hits:  35%/51510 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  4h 00m | Avg:  1h 00m | Max:  1h 01m | Hits:  22%/4880  
  🟩 Clang15            Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 03m | Hits:  22%/2436  
  🟩 Clang16            Pass: 100%/2   | Total:  2h 10m | Avg:  1h 05m | Max:  1h 05m | Hits:  22%/2436  
  🟩 Clang17            Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m | Hits:  22%/2436  
  🟩 Clang18            Pass: 100%/7   | Total:  5h 57m | Avg: 51m 04s | Max:  1h 04m | Hits:  45%/8194  
  🟩 GCC7               Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 08m | Hits:  22%/2440  
  🟩 GCC8               Pass: 100%/1   | Total:  1h 14m | Avg:  1h 14m | Max:  1h 14m | Hits:  22%/1220  
  🟩 GCC9               Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 03m | Hits:  22%/2440  
  🟩 GCC10              Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 02m | Hits:  22%/2440  
  🟩 GCC11              Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 08m | Hits:  22%/2436  
  🟩 GCC12              Pass: 100%/2   | Total:  2h 13m | Avg:  1h 06m | Max:  1h 06m | Hits:  22%/2436  
  🟩 GCC13              Pass: 100%/11  | Total:  7h 24m | Avg: 40m 25s | Max:  1h 22m | Hits:  64%/13398 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 26m | Avg:  1h 13m | Max:  1h 19m | Hits:  12%/2084  
  🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 41m | Avg:  1h 20m | Max:  1h 23m | Hits:  12%/2084  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total: 16h 12m | Avg: 57m 12s | Max:  1h 05m | Hits:  31%/20382 
  🟩 GCC                Pass: 100%/22  | Total: 19h 18m | Avg: 52m 39s | Max:  1h 22m | Hits:  43%/26810 
  🟩 MSVC               Pass: 100%/4   | Total:  5h 08m | Avg:  1h 17m | Max:  1h 23m | Hits:  12%/4168  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 14m | Hits:  18%/2254  
🟩 gpu
  🟩 h100               Pass: 100%/3   | Total:  1h 18m | Avg: 26m 00s | Max: 31m 16s | Hits:  73%/3654  
  🟩 rtx2080            Pass: 100%/34  | Total:  1d 13h | Avg:  1h 06m | Max:  1h 23m | Hits:  21%/40216 
  🟩 rtxa6000           Pass: 100%/8   | Total:  4h 21m | Avg: 32m 37s | Max:  1h 07m | Hits:  80%/9744  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  1d 16h | Avg:  1h 05m | Max:  1h 23m | Hits:  21%/43870 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 22m 39s | Avg: 22m 39s | Max: 22m 39s | Hits:  99%/1218  
  🟩 GraphCapture       Pass: 100%/1   | Total: 17m 30s | Avg: 17m 30s | Max: 17m 30s | Hits:  99%/1218  
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 09m | Avg: 23m 03s | Max: 23m 56s | Hits:  99%/3654  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 07m | Avg: 22m 39s | Max: 23m 29s | Hits:  99%/3654  
🟩 sm
  🟩 90                 Pass: 100%/3   | Total:  1h 18m | Avg: 26m 00s | Max: 31m 16s | Hits:  73%/3654  
  🟩 90;90a;100         Pass: 100%/1   | Total:  1h 22m | Avg:  1h 22m | Max:  1h 22m | Hits:  22%/1218  
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 21h 59m | Avg:  1h 05m | Max:  1h 23m | Hits:  20%/23591 
  🟩 20                 Pass: 100%/25  | Total: 21h 03m | Avg: 50m 33s | Max:  1h 22m | Hits:  46%/30023

🟩 thrust: Pass: 100%/45 | Total: 1d 01h | Avg: 33m 29s | Max: 1h 09m | Hits: 57%/79956

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 40m 11s | Avg: 20m 05s | Max: 29m 35s | Hits:  74%/3556  
🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 00h | Avg: 33m 38s | Max:  1h 09m | Hits:  57%/76401 
  🟩 arm64              Pass: 100%/2   | Total:  1h 00m | Avg: 30m 16s | Max: 31m 48s | Hits:  50%/3555  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 15m | Avg: 39m 03s | Max:  1h 07m | Hits:  47%/8881  
  🟩 12.5               Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
  🟩 12.8               Pass: 100%/38  | Total: 19h 48m | Avg: 31m 16s | Max:  1h 09m | Hits:  60%/67521 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 53m 53s | Avg: 26m 56s | Max: 26m 59s | Hits:  50%/3554  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 15m | Avg: 39m 03s | Max:  1h 07m | Hits:  47%/8881  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
  🟩 nvcc12.8           Pass: 100%/36  | Total: 18h 54m | Avg: 31m 30s | Max:  1h 09m | Hits:  60%/63967 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 53m 53s | Avg: 26m 56s | Max: 26m 59s | Hits:  50%/3554  
  🟩 nvcc               Pass: 100%/43  | Total:  1d 00h | Avg: 33m 48s | Max:  1h 09m | Hits:  57%/76402 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 08m | Avg: 32m 10s | Max: 32m 41s | Hits:  57%/7108  
  🟩 Clang15            Pass: 100%/2   | Total:  1h 05m | Avg: 32m 42s | Max: 35m 21s | Hits:  50%/3554  
  🟩 Clang16            Pass: 100%/2   | Total:  1h 13m | Avg: 36m 48s | Max: 38m 42s | Hits:  50%/3554  
  🟩 Clang17            Pass: 100%/2   | Total:  1h 08m | Avg: 34m 01s | Max: 35m 53s | Hits:  50%/3554  
  🟩 Clang18            Pass: 100%/7   | Total:  2h 41m | Avg: 23m 05s | Max: 30m 56s | Hits:  65%/12439 
  🟩 GCC7               Pass: 100%/2   | Total:  1h 02m | Avg: 31m 20s | Max: 31m 57s | Hits:  62%/3556  
  🟩 GCC8               Pass: 100%/1   | Total: 31m 44s | Avg: 31m 44s | Max: 31m 44s | Hits:  50%/1778  
  🟩 GCC9               Pass: 100%/2   | Total:  1h 06m | Avg: 33m 12s | Max: 33m 18s | Hits:  58%/3556  
  🟩 GCC10              Pass: 100%/2   | Total:  1h 06m | Avg: 33m 22s | Max: 34m 09s | Hits:  50%/3556  
  🟩 GCC11              Pass: 100%/2   | Total:  1h 06m | Avg: 33m 09s | Max: 34m 25s | Hits:  50%/3556  
  🟩 GCC12              Pass: 100%/2   | Total:  1h 08m | Avg: 34m 13s | Max: 35m 22s | Hits:  50%/3556  
  🟩 GCC13              Pass: 100%/10  | Total:  3h 35m | Avg: 21m 32s | Max: 33m 11s | Hits:  75%/17780 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 07m | Hits:  30%/3542  
  🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 53m | Avg: 57m 50s | Max:  1h 09m | Hits:  40%/5313  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  8h 17m | Avg: 29m 15s | Max: 38m 42s | Hits:  58%/30209 
  🟩 GCC                Pass: 100%/21  | Total:  9h 37m | Avg: 27m 30s | Max: 35m 22s | Hits:  64%/37338 
  🟩 MSVC               Pass: 100%/5   | Total:  5h 08m | Avg:  1h 01m | Max:  1h 09m | Hits:  36%/8855  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 03m | Avg:  1h 01m | Max:  1h 02m | Hits:  32%/3554  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 31m 30s | Avg: 15m 45s | Max: 20m 30s | Hits:  75%/3556  
  🟩 rtx2080            Pass: 100%/33  | Total: 20h 34m | Avg: 37m 23s | Max:  1h 08m | Hits:  50%/58637 
  🟩 rtx4090            Pass: 100%/10  | Total:  4h 01m | Avg: 24m 11s | Max:  1h 09m | Hits:  77%/17763 
🟩 jobs
  🟩 Build              Pass: 100%/38  | Total: 23h 34m | Avg: 37m 13s | Max:  1h 09m | Hits:  50%/67519 
  🟩 TestCPU            Pass: 100%/3   | Total: 50m 16s | Avg: 16m 45s | Max: 35m 07s | Hits:  90%/5326  
  🟩 TestGPU            Pass: 100%/4   | Total: 42m 53s | Avg: 10m 43s | Max: 11m 00s | Hits:  99%/7111  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 31m 30s | Avg: 15m 45s | Max: 20m 30s | Hits:  75%/3556  
  🟩 90;90a;100         Pass: 100%/1   | Total: 30m 33s | Avg: 30m 33s | Max: 30m 33s | Hits:  76%/1778  
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 13h 13m | Avg: 39m 39s | Max:  1h 08m | Hits:  49%/35531 
  🟩 20                 Pass: 100%/23  | Total: 11h 14m | Avg: 29m 18s | Max:  1h 09m | Hits:  63%/40869

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 10s | Avg: 8m 05s | Max: 13m 34s | Hits: 97%/308

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 16m 10s | Avg:  8m 05s | Max: 13m 34s | Hits:  97%/308   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 36s | Avg:  2m 36s | Max:  2m 36s | Hits:  95%/154   
  🟩 Test               Pass: 100%/1   | Total: 13m 34s | Avg: 13m 34s | Max: 13m 34s | Hits:  98%/154

🟩 python: Pass: 100%/1 | Total: 1h 00m | Avg: 1h 00m | Max: 1h 00m

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total:  1h 00m | Avg:  1h 00m | Max:  1h 00m

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
+/-	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 93)

#	Runner
66	`linux-amd64-cpu16`
9	`windows-amd64-cpu16`
6	`linux-amd64-gpu-rtxa6000-latest-1`
4	`linux-arm64-cpu16`
3	`linux-amd64-gpu-h100-latest-1`
3	`linux-amd64-gpu-rtx4090-latest-1`
2	`linux-amd64-gpu-rtx2080-latest-1`

bernhardmgruber changed the title ~~Rework counting iterator~~ Rework counting iterator difference Feb 19, 2025

bernhardmgruber commented Feb 19, 2025

View reviewed changes

thrust/thrust/iterator/counting_iterator.h Outdated Show resolved Hide resolved

bernhardmgruber commented Feb 19, 2025

View reviewed changes

thrust/thrust/iterator/counting_iterator.h Outdated Show resolved Hide resolved

bernhardmgruber added 3 commits March 5, 2025 18:53

Add tests for counting_iterator difference_type

b9dea3d

Rework counting_iterator difference_type

22d84f4

Fix

3ce4241

bernhardmgruber force-pushed the rework_counting_iterator branch from 863e0df to 3ce4241 Compare March 5, 2025 17:59

Simplify

afbb5d1

bernhardmgruber marked this pull request as ready for review March 5, 2025 18:03

bernhardmgruber requested a review from a team as a code owner March 5, 2025 18:03

bernhardmgruber requested a review from elstehle March 5, 2025 18:03

bernhardmgruber changed the title ~~Rework counting iterator difference~~ Rework counting_iterator difference Mar 5, 2025

miscco approved these changes Mar 5, 2025

View reviewed changes

bernhardmgruber added thrust For all items related to Thrust. breaking Breaking change labels Mar 6, 2025

bernhardmgruber merged commit dad67ba into NVIDIA:main Mar 6, 2025
107 of 110 checks passed

bernhardmgruber deleted the rework_counting_iterator branch March 6, 2025 08:35

bernhardmgruber mentioned this pull request Mar 6, 2025

[EPIC] Breaking changes for CCCL 3.0 #101

Open

89 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework counting_iterator difference #3861

Rework counting_iterator difference #3861

bernhardmgruber commented Feb 19, 2025 •

edited

Loading

copy-pr-bot bot commented Feb 19, 2025

bernhardmgruber Feb 19, 2025

miscco left a comment

github-actions bot commented Mar 5, 2025

🟥 python: Pass: 0%/1 | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s

🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 24s | Max: 1h 23m | Hits: 35%/53614

🟩 thrust: Pass: 100%/45 | Total: 1d 01h | Avg: 33m 29s | Max: 1h 09m | Hits: 57%/79956

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 10s | Avg: 8m 05s | Max: 13m 34s | Hits: 97%/308

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 93)

github-actions bot commented Mar 5, 2025

🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 24s | Max: 1h 23m | Hits: 35%/53614

🟩 thrust: Pass: 100%/45 | Total: 1d 01h | Avg: 33m 29s | Max: 1h 09m | Hits: 57%/79956

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 10s | Avg: 8m 05s | Max: 13m 34s | Hits: 97%/308

🟩 python: Pass: 100%/1 | Total: 1h 00m | Avg: 1h 00m | Max: 1h 00m

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 93)

		static_assert(diff_type_is<__int128_t, ptrdiff_t>);
		static_assert(diff_type_is<__uint128_t, ptrdiff_t>);

Rework counting_iterator difference #3861

Rework counting_iterator difference #3861

Conversation

bernhardmgruber commented Feb 19, 2025 • edited Loading

copy-pr-bot bot commented Feb 19, 2025

bernhardmgruber Feb 19, 2025

Choose a reason for hiding this comment

miscco left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 5, 2025

🟥 python: Pass: 0%/1 | Total: 16m 11s | Avg: 16m 11s | Max: 16m 11s

🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 24s | Max: 1h 23m | Hits: 35%/53614

🟩 thrust: Pass: 100%/45 | Total: 1d 01h | Avg: 33m 29s | Max: 1h 09m | Hits: 57%/79956

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 10s | Avg: 8m 05s | Max: 13m 34s | Hits: 97%/308

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 93)

github-actions bot commented Mar 5, 2025

🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 24s | Max: 1h 23m | Hits: 35%/53614

🟩 thrust: Pass: 100%/45 | Total: 1d 01h | Avg: 33m 29s | Max: 1h 09m | Hits: 57%/79956

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 16m 10s | Avg: 8m 05s | Max: 13m 34s | Hits: 97%/308

🟩 python: Pass: 100%/1 | Total: 1h 00m | Avg: 1h 00m | Max: 1h 00m

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 93)

bernhardmgruber commented Feb 19, 2025 •

edited

Loading