Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Self Paced Training - Chapter 4. #3243

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[WIP] Self Paced Training - Chapter 4. #3243

wants to merge 9 commits into from

Conversation

zhijinl
Copy link
Contributor

@zhijinl zhijinl commented Feb 20, 2025 •
edited
Loading

Description

Add content for Self Paced Training - Chapter 4:

  • [COMPLETED] 04.0_introduction
  • [COMPLETED] 04.1_provision_via_cli
  • [COMPLETED] 04.2_provision_via_dashboard
  • [COMPLETED] 04.3_preflight_check
  • [COMPLETED] 04.4_provision_and_run_with_docker
  • [COMPLETED] 04.5_deployment_in_aws
  • [COMPLETED] 04.6_deployment_in_azure
  • [COMPLETED] 04.7_provision_and_run_with_k8s
  • [COMPLETED] 04.8_recap

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. make a comment for preflight check output

@zhijinl
Copy link
Contributor Author

zhijinl commented Feb 21, 2025

@chesterxgchen Added more commits to finish the WIP sections, should be all finished now for review

chesterxgchen
chesterxgchen approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen
Copy link
Collaborator

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhijinl @chesterxgchen