Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FedStats Quantile and Tutorials Update #3241

Merged
merged 27 commits into from
Feb 25, 2025

Conversation

chesterxgchen
Copy link
Collaborator

@chesterxgchen chesterxgchen commented Feb 19, 2025

FedStats Quantile metrics

  • Replace t-digest python package ( which require python3-dev dependency) with fastdigest ( which requires cargo rust dependency). Make the installation of fastdigest optional
  • move make the quantile optional, only available when fastquantile is installed.

Tutorial 2nd Pass Update

  1. Chapter 1 -- introduction to logging section
  2. Chapter 2 -- Update
    • Chapter 2.1 -- Expand the fed statistics with background and explanation
    • Chapter 2.2 -- Expand the Client API section with additional figure and details tutorials
    • Chapter 2.3 -- re-organized the section make client API goes first. Add a lot details for logistics regression, removed the Job API code, As it doesn't work right now.
    • Chapter 2.5 --recap, re-write the summary to avoid it as the repeat of the introduction
  3. Chapter 1-2-3 grammar check update

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen chesterxgchen marked this pull request as draft February 19, 2025 20:10
@chesterxgchen chesterxgchen marked this pull request as ready for review February 20, 2025 04:01
@chesterxgchen
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen force-pushed the fed_stats2 branch 4 times, most recently from 129ece4 to 6078da3 Compare February 23, 2025 04:19
@chesterxgchen chesterxgchen changed the title Re-implement FedStats Quantile FedStats Quantile and Tutorials Update Feb 23, 2025
@chesterxgchen
Copy link
Collaborator Author

/build

1 similar comment
@chesterxgchen
Copy link
Collaborator Author

/build

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder inside Chapter 2.4 should be 2.4.xx

@chesterxgchen
Copy link
Collaborator Author

/build

@chesterxgchen
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit db75f43 into NVIDIA:main Feb 25, 2025
20 checks passed
@chesterxgchen chesterxgchen deleted the fed_stats2 branch February 25, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants