Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meta, enable uint8 quantization, and update server filter behavior #3222

Merged
merged 17 commits into from
Feb 22, 2025
Merged

Remove meta, enable uint8 quantization, and update server filter behavior #3222

merged 17 commits into from
Feb 22, 2025

Conversation

ZiyueXu77
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 commented Feb 13, 2025 •
edited
Loading

Fixes # .

Description

Bug in dequantization meta removal, also enabling uint8 quantization
Most importantly, update server behavior so that it will send correct message to multiple clients

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77 ZiyueXu77 requested a review from nvidianz February 13, 2025 19:03
@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) February 13, 2025 20:30
@ZiyueXu77 ZiyueXu77 changed the title Remove meta and enable uint8 quantization Remove meta, enable uint8 quantization, and update server filter behavior Feb 14, 2025
@ZiyueXu77 ZiyueXu77 mentioned this pull request Feb 14, 2025
Closed
@ZiyueXu77 ZiyueXu77 requested a review from yanchengnv February 14, 2025 16:42
@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions

YuanTingHsieh
YuanTingHsieh previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@ZiyueXu77 ZiyueXu77 merged commit 3aefb2d into NVIDIA:main Feb 22, 2025
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the quant_fix branch February 22, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@nvidianz nvidianz Awaiting requested review from nvidianz

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueXu77 @YuanTingHsieh