Alternative interface to EQN_OF_STATE="LINEAR" #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
requested changes
Feb 24, 2025
Hallberg-NOAA
approved these changes
Feb 24, 2025
The existing interface to EQN_OF_STATE="LINEAR" is based on RHO_T0_S0, the density at T=0, S=0. This is the most computationally efficient way to specify a linear EOS, but we are usually linearizing about a reference T and S that are not 0. The new interface is based on TREF, SREF, and RHO_TREF_SREF, where: RHO(T,S) = RHO_TREF_SREF + DRHO_DT*(T-TREF) + DRHO_DS*(S-SREF) RHO_T0_S0 = RHO_TREF_SREF - DRHO_DT*TREF - DRHO_DS*SREF RHO(T,S) = RHO_T0_S0 + DRHO_DT*T + DRHO_DS*S The defaults for TREF and SREF are zero and for RHO_TREF_SREF is 1000.0. So if the new interface is not used answers are not changed but there are always new model parameters.
Hallberg-NOAA
force-pushed
the
EOS_LINEAR
branch
from
687b9aa to
5a6e7c8
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26515 with the expected warnings about new runtime parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing interface to EQN_OF_STATE="LINEAR" is based on RHO_T0_S0, the
density at T=0, S=0. This is the most computationally efficient way to
specify a linear EOS, but we are usually linearizing about a reference
T and S that are not 0.
The new interface is based on TREF, SREF, and RHO_TREF_SREF, where:
RHO(T,S) = RHO_TREF_SREF + DRHO_DT*(T-TREF) + DRHO_DS*(S-SREF)
RHO_T0_S0 = RHO_TREF_SREF - DRHO_DTTREF - DRHO_DSSREF
RHO(T,S) = RHO_T0_S0 + DRHO_DTT + DRHO_DSS
The defaults for TREF and SREF are zero and for RHO_TREF_SREF is 1000.0.
So if the new interface is not used answers are not changed but there
are always new model parameters.