Skip to content

Commit

Permalink
Remove Prandtl_turb in vertvisc_type
Browse files Browse the repository at this point in the history
The field is never used by MOM_set_visc and incorrectly logged under
MOM_set_visc section in MOM_parameter_doc, rather than MOM_kappa_shear.
  • Loading branch information
herrwang0 authored and Hallberg-NOAA committed Feb 23, 2025
1 parent 0162098 commit e187090
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
2 changes: 0 additions & 2 deletions src/core/MOM_variables.F90
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,6 @@ module MOM_variables

!> Vertical viscosities, drag coefficients, and related fields.
type, public :: vertvisc_type
real :: Prandtl_turb !< The Prandtl number for the turbulent diffusion
!! that is captured in Kd_shear [nondim].
real, allocatable, dimension(:,:) :: &
bbl_thick_u, & !< The bottom boundary layer thickness at the u-points [Z ~> m].
bbl_thick_v, & !< The bottom boundary layer thickness at the v-points [Z ~> m].
Expand Down
2 changes: 1 addition & 1 deletion src/parameterizations/vertical/MOM_kappa_shear.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1969,7 +1969,7 @@ function kappa_shear_init(Time, G, GV, US, param_file, diag, CS)
default=13, do_not_log=just_read)
call get_param(param_file, mdl, "PRANDTL_TURB", CS%Prandtl_turb, &
"The turbulent Prandtl number applied to shear instability.", &
units="nondim", default=1.0, do_not_log=.true.)
units="nondim", default=1.0, do_not_log=just_read)
call get_param(param_file, mdl, "VEL_UNDERFLOW", CS%vel_underflow, &
"A negligibly small velocity magnitude below which velocity components are set "//&
"to 0. A reasonable value might be 1e-30 m/s, which is less than an "//&
Expand Down
3 changes: 0 additions & 3 deletions src/parameterizations/vertical/MOM_set_viscosity.F90
Original file line number Diff line number Diff line change
Expand Up @@ -2956,9 +2956,6 @@ subroutine set_visc_init(Time, G, GV, US, param_file, diag, visc, CS, restart_CS
CS%RiNo_mix = kappa_shear_is_used(param_file)
endif

call get_param(param_file, mdl, "PRANDTL_TURB", visc%Prandtl_turb, &
"The turbulent Prandtl number applied to shear "//&
"instability.", units="nondim", default=1.0)
call get_param(param_file, mdl, "DEBUG", CS%debug, default=.false.)

call get_param(param_file, mdl, "DYNAMIC_VISCOUS_ML", CS%dynamic_viscous_ML, &
Expand Down

0 comments on commit e187090

Please sign in to comment.