-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enkf archive jobs to use COMIN/COMOUT #3393
Update enkf archive jobs to use COMIN/COMOUT #3393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COM_TOP should not have been in the archive jobs to begin with, so please just go ahead and delete them. Changes look good otherwise.
jobs/JGDAS_ENKF_ARCHIVE_TARS
Outdated
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
COMIN_TOP:COM_TOP_TMPL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through the archive scripts and config files, I do not see any references to COM*TOP
, so I think I put this in here by accident. Instead of renaming this to COMIN_TOP, let's just get rid of the variable.
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | |
COMIN_TOP:COM_TOP_TMPL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidHuber-NOAA
I agree with your comments. I have removed COM*TOP variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was a holdover from before the cleanup job was broken out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Approve pending successful CI testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks @mingshichen-noaa ! Approve pending successfully completion of CI tests.
@DavidHuber-NOAA |
CI Passed on Hercules in Build# 1
|
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ENKF_ARCHIVE_TARS and JGDAS_ENKF_ARCHIVE_VRFY jobs and associated bash and python scripts
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist